Type of InstanceMirror on class should still be a ClassMirror when class has call method

Type of InstanceMirror on class should still be a ClassMirror when class has call method

BUG= https://github.com/dart-lang/sdk/issues/28864
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/fc56b59a88d963475af5db1b3fefad3bf6de07ea

[sra1, 2017-03-07 23:56:20]

Patchset #2 (id:20001) has been deleted

[sra1, 2017-03-07 23:56:27]

Patchset #1 (id:1) has been deleted

[sra1, 2017-03-07 23:57:26]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2017-03-07 23:57:27]

This fixes https://github.com/dart-lang/sdk/issues/28864

[Siggi Cherem (dart-lang), 2017-03-08 00:10:27]

lgtm

could you also add to function_type_mirror_test an extra test case for `A.call`?

Seems like we don't have coverage for that specific case.

[sra1, 2017-03-08 00:25:47]

On 2017/03/08 00:10:27, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
> could you also add to function_type_mirror_test an extra test case for
`A.call`?
> 
> Seems like we don't have coverage for that specific case.

That does not work on the VM either.
We are consistent now with the unspecified and unhelpful VM behaviour:
The VM returns a ClassMirror as the .type of a ClosureMirror on A.


Hence the comment:

 2310     // TODO(sra): Should there be a TypeMirror that is both a ClassMirror
and
 2311     // FunctionTypeMirror?

[Siggi Cherem (dart-lang), 2017-03-08 00:26:32]

ok

[sra1, 2017-03-08 00:57:17]

On 2017/03/08 00:26:32, Siggi Cherem (dart-lang) wrote:
> ok

It is covered by fake_function_with_call_test, which continues to fail for other
reasons.

[sra1, 2017-03-08 00:57:38]

Patchset #1 (id:40001) has been deleted

[sra1, 2017-03-08 01:08:54]

Description was changed from

==========
Type of InstanceMirror on class should still be a ClassMirror when class has
call method

BUG= https://github.com/dart-lang/sdk/issues/28864
==========

to

==========
Type of InstanceMirror on class should still be a ClassMirror when class has
call method

BUG= https://github.com/dart-lang/sdk/issues/28864
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fc56b59a88d963475af5db1b3fefad3bf6de07ea
==========

[sra1, 2017-03-08 01:08:55]

Committed patchset #1 (id:60001) manually as
fc56b59a88d963475af5db1b3fefad3bf6de07ea (presubmit successful).