Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2735973006: Bindings: Separate WorldIdConstants into WorldTypes and WorldId (Closed)
Patch Set: address review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp ('K') | « third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index cb38d4bac6eddaab09f30c0080a9bf208f8f4848..6c10f4be03c66f4279d660a47b3f521dd34c6b99 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -671,7 +671,7 @@ void WebLocalFrameImpl::executeScriptInIsolatedWorld(
unsigned numSources) {
DCHECK(frame());
CHECK_GT(worldID, 0);
- CHECK_LT(worldID, EmbedderWorldIdLimit);
+ CHECK_LT(worldID, DOMWrapperWorld::EmbedderWorldIdLimit);
HeapVector<ScriptSourceCode> sources =
createSourcesVector(sourcesIn, numSources);
@@ -775,7 +775,7 @@ void WebLocalFrameImpl::executeScriptInIsolatedWorld(
WebVector<v8::Local<v8::Value>>* results) {
DCHECK(frame());
CHECK_GT(worldID, 0);
- CHECK_LT(worldID, EmbedderWorldIdLimit);
+ CHECK_LT(worldID, DOMWrapperWorld::EmbedderWorldIdLimit);
HeapVector<ScriptSourceCode> sources =
createSourcesVector(sourcesIn, numSources);
@@ -803,7 +803,7 @@ void WebLocalFrameImpl::requestExecuteScriptInIsolatedWorld(
WebScriptExecutionCallback* callback) {
DCHECK(frame());
CHECK_GT(worldID, 0);
- CHECK_LT(worldID, EmbedderWorldIdLimit);
+ CHECK_LT(worldID, DOMWrapperWorld::EmbedderWorldIdLimit);
SuspendableScriptExecutor::createAndRun(
frame(), worldID, createSourcesVector(sourcesIn, numSources), userGesture,
« third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp ('K') | « third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698