Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp

Issue 2735973006: Bindings: Separate WorldIdConstants into WorldTypes and WorldId (Closed)
Patch Set: address review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/xml/DocumentXMLTreeViewer.h" 5 #include "core/xml/DocumentXMLTreeViewer.h"
6 6
7 #include "bindings/core/v8/DOMWrapperWorld.h" 7 #include "bindings/core/v8/DOMWrapperWorld.h"
8 #include "bindings/core/v8/ScriptController.h" 8 #include "bindings/core/v8/ScriptController.h"
9 #include "bindings/core/v8/ScriptSourceCode.h" 9 #include "bindings/core/v8/ScriptSourceCode.h"
10 #include "bindings/core/v8/V8PerIsolateData.h" 10 #include "bindings/core/v8/V8PerIsolateData.h"
11 #include "core/dom/Document.h" 11 #include "core/dom/Document.h"
12 #include "core/dom/Element.h" 12 #include "core/dom/Element.h"
13 #include "core/frame/LocalFrame.h" 13 #include "core/frame/LocalFrame.h"
14 #include "platform/PlatformResourceLoader.h" 14 #include "platform/PlatformResourceLoader.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 void transformDocumentToXMLTreeView(Document& document) { 18 void transformDocumentToXMLTreeView(Document& document) {
19 String scriptString = loadResourceAsASCIIString("DocumentXMLTreeViewer.js"); 19 String scriptString = loadResourceAsASCIIString("DocumentXMLTreeViewer.js");
20 String cssString = loadResourceAsASCIIString("DocumentXMLTreeViewer.css"); 20 String cssString = loadResourceAsASCIIString("DocumentXMLTreeViewer.css");
21 21
22 HeapVector<ScriptSourceCode> sources; 22 HeapVector<ScriptSourceCode> sources;
23 sources.push_back(ScriptSourceCode(scriptString)); 23 sources.push_back(ScriptSourceCode(scriptString));
24 v8::HandleScope handleScope(V8PerIsolateData::mainThreadIsolate()); 24 v8::HandleScope handleScope(V8PerIsolateData::mainThreadIsolate());
25 25
26 document.frame()->script().executeScriptInIsolatedWorld( 26 document.frame()->script().executeScriptInIsolatedWorld(
27 WorldIdConstants::DocumentXMLTreeViewerWorldId, sources, nullptr); 27 DOMWrapperWorld::DocumentXMLTreeViewerWorldId, sources, nullptr);
Yuki 2017/03/08 14:07:51 Should DocumentXMLTreeViewerWorldId be also a new
nhiroki 2017/03/09 03:40:29 This is a part of IsolatedWorlds and doesn't need
28 28
29 Element* element = document.getElementById("xml-viewer-style"); 29 Element* element = document.getElementById("xml-viewer-style");
30 if (element) { 30 if (element) {
31 element->setTextContent(cssString); 31 element->setTextContent(cssString);
32 } 32 }
33 } 33 }
34 34
35 } // namespace blink 35 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698