Bindings: Separate WorldIdConstants into WorldTypes and WorldId

third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include "platform/weborigin/SecurityOrigin.h"
 #include "v8/include/v8.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class DOMDataStore;
 
-enum WorldIdConstants {
+// Per-thread global identifiers for DOMWrapperWorld.
+enum WorldIdSpace {

[peria, 2017/03/08 09:48:19]

Can you move this enum into DOMWrapperWorld class?
And I prefer 'WorldId' for its type name.

[nhiroki, 2017/03/08 10:24:53]

Done.

+  UnknownWorldId = -1,
   MainWorldId = 0,
   // Embedder isolated worlds can use IDs in [1, 1<<29).
   EmbedderWorldIdLimit = (1 << 29),
   DocumentXMLTreeViewerWorldId,
   IsolatedWorldIdLimit,
   WorkerWorldId,
-  TestingWorldId,
+};
+
+enum class WorldType {
+  Unknown,
+  Main,
+  Isolated,
+  Worker,
 };
 
 class DOMObjectHolderBase;
 
-// This class represent a collection of DOM wrappers for a specific world.
+// This class represent a collection of DOM wrappers for a specific world. This
+// is identified by a world id that is a per-thread global identifier (see
+// WorldIdSpace above).
 class CORE_EXPORT DOMWrapperWorld : public RefCounted<DOMWrapperWorld> {
  public:
-  static PassRefPtr<DOMWrapperWorld> create(v8::Isolate*, int worldId = -1);
+  // Creates a world other than IsolatedWorld.
+  static PassRefPtr<DOMWrapperWorld> create(v8::Isolate*, WorldType);
 
+  // Ensures an IsolatedWorld for |worldId|.
   static PassRefPtr<DOMWrapperWorld> ensureIsolatedWorld(v8::Isolate*,
                                                          int worldId);
   ~DOMWrapperWorld();
   void dispose();
 
   static bool isolatedWorldsExist() { return isolatedWorldCount; }
   static void allWorldsInMainThread(Vector<RefPtr<DOMWrapperWorld>>& worlds);
   static void markWrappersInAllWorlds(ScriptWrappable*,
                                       const ScriptWrappableVisitor*);
 
@@ skipping 24 matching lines @@
   // world should be restricted based on the isolated world's DOM, not the
   // main world's.
   //
   // FIXME: Right now, resource injection simply bypasses the main world's
   // DOM. More work is necessary to allow the isolated world's policy to be
   // applied correctly.
   static void setIsolatedWorldContentSecurityPolicy(int worldId,
                                                     const String& policy);
   bool isolatedWorldHasContentSecurityPolicy();
 
-  bool isMainWorld() const { return m_worldId == MainWorldId; }
-  bool isWorkerWorld() const { return m_worldId == WorkerWorldId; }
-  bool isIsolatedWorld() const {
-    return MainWorldId < m_worldId && m_worldId < IsolatedWorldIdLimit;
-  }
+  bool isMainWorld() const { return m_worldType == WorldType::Main; }
+  bool isWorkerWorld() const { return m_worldType == WorldType::Worker; }
+  bool isIsolatedWorld() const { return m_worldType == WorldType::Isolated; }
 
   int worldId() const { return m_worldId; }
   DOMDataStore& domDataStore() const { return *m_domDataStore; }
 
  public:
   template <typename T>
   void registerDOMObjectHolder(v8::Isolate*, T*, v8::Local<v8::Value>);
 
  private:
-  DOMWrapperWorld(v8::Isolate*, int worldId);
+  DOMWrapperWorld(v8::Isolate*, WorldType, int worldId);
 
   static void weakCallbackForDOMObjectHolder(
       const v8::WeakCallbackInfo<DOMObjectHolderBase>&);
   void registerDOMObjectHolderInternal(std::unique_ptr<DOMObjectHolderBase>);
   void unregisterDOMObjectHolder(DOMObjectHolderBase*);
 
   static unsigned isolatedWorldCount;
 
+  const WorldType m_worldType;
   const int m_worldId;
   std::unique_ptr<DOMDataStore> m_domDataStore;
   HashSet<std::unique_ptr<DOMObjectHolderBase>> m_domObjectHolders;
 };
 
 }  // namespace blink
 
 #endif  // DOMWrapperWorld_h