Bindings: Separate WorldIdConstants into WorldTypes and WorldId

third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "bindings/core/v8/WindowProxy.h"
 #include "bindings/core/v8/WrapperTypeInfo.h"
 #include "core/dom/ExecutionContext.h"
 #include "wtf/HashTraits.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/StdLibExtras.h"
 #include <memory>
 
 namespace blink {
 
+// Returns an identifier for a given world type other than WorldType::Isolated.
+// IsolatedWorld has its unique convention to allocate an identifier.
+int getWorldIdForType(WorldType worldType) {
+  switch (worldType) {
+    case WorldType::Unknown:
+      return UnknownWorldId;
+    case WorldType::Main:
+      return MainWorldId;
+    case WorldType::Isolated:
+      NOTREACHED();

[haraken, 2017/03/08 09:39:09]

Why is it not reached?

[nhiroki, 2017/03/08 10:24:52]

Because IsolatedWorld is created by DOMWrapperWorld::ensureIsolatedWorld that
doesn't call this function.

[haraken, 2017/03/08 10:27:47]

Hmm. So an ID for an isolated world is provided externally. Then who provides an
ID for a worker/worklet world?

We need to somehow make sure that there's no conflict in the IDs.

[nhiroki, 2017/03/08 10:44:22]

That's right.
I'll make a dynamic allocation mechanism for a worker/worklet world in
https://codereview.chromium.org/2735823006/ (not updated yet). It will pick up
an ID from the unused range [WorkerWorldId, INT_MAX) and getWorldIdForType()
calls it, so it never conflict with others. (Probably getWorldIdForType will be
renamed to generateWorldIdForType or something at the time)

+      return -1;
+    // Currently, WorldId for a worker/worklet is fixed value, but this doesn't

[peria, 2017/03/08 09:48:19]

*a* fixed value

[nhiroki, 2017/03/08 10:24:52]

Done.

+    // work when multiple worklets are created on a thread.
+    // TODO(nhiroki): Expand the identifier space for workers/worklets.
+    case WorldType::Worker:
+      return WorkerWorldId;
+  }
+  NOTREACHED();
+  return -1;
+}
+
 class DOMObjectHolderBase {
   USING_FAST_MALLOC(DOMObjectHolderBase);
 
  public:
   DOMObjectHolderBase(v8::Isolate* isolate, v8::Local<v8::Value> wrapper)
-      : m_wrapper(isolate, wrapper), m_world(0) {}
+      : m_wrapper(isolate, wrapper), m_world(nullptr) {}
   virtual ~DOMObjectHolderBase() {}
 
   DOMWrapperWorld* world() const { return m_world; }
   void setWorld(DOMWrapperWorld* world) { m_world = world; }
   void setWeak(
       void (*callback)(const v8::WeakCallbackInfo<DOMObjectHolderBase>&)) {
     m_wrapper.setWeak(this, callback);
   }
 
  private:
@@ skipping 12 matching lines @@
  private:
   DOMObjectHolder(v8::Isolate* isolate, T* object, v8::Local<v8::Value> wrapper)
       : DOMObjectHolderBase(isolate, wrapper), m_object(object) {}
 
   Persistent<T> m_object;
 };
 
 unsigned DOMWrapperWorld::isolatedWorldCount = 0;
 
 PassRefPtr<DOMWrapperWorld> DOMWrapperWorld::create(v8::Isolate* isolate,
-                                                    int worldId) {
-  return adoptRef(new DOMWrapperWorld(isolate, worldId));
+                                                    WorldType worldType) {
+  DCHECK_NE(WorldType::Isolated, worldType);
+  return adoptRef(
+      new DOMWrapperWorld(isolate, worldType, getWorldIdForType(worldType)));
 }
 
-DOMWrapperWorld::DOMWrapperWorld(v8::Isolate* isolate, int worldId)
-    : m_worldId(worldId),
+DOMWrapperWorld::DOMWrapperWorld(v8::Isolate* isolate,
+                                 WorldType worldType,
+                                 int worldId)
+    : m_worldType(worldType),
+      m_worldId(worldId),
       m_domDataStore(
           WTF::wrapUnique(new DOMDataStore(isolate, isMainWorld()))) {
-  if (worldId == WorkerWorldId) {
+  if (isWorkerWorld())
     workerWorld() = this;
-  }
 }
 
 DOMWrapperWorld& DOMWrapperWorld::mainWorld() {
   ASSERT(isMainThread());
   DEFINE_STATIC_REF(
       DOMWrapperWorld, cachedMainWorld,
-      (DOMWrapperWorld::create(v8::Isolate::GetCurrent(), MainWorldId)));
+      (DOMWrapperWorld::create(v8::Isolate::GetCurrent(), WorldType::Main)));
   return *cachedMainWorld;
 }
 
 DOMWrapperWorld*& DOMWrapperWorld::workerWorld() {
   DEFINE_THREAD_SAFE_STATIC_LOCAL(ThreadSpecific<DOMWrapperWorld*>, workerWorld,
                                   new ThreadSpecific<DOMWrapperWorld*>);
   return *workerWorld;
 }
 
 PassRefPtr<DOMWrapperWorld> DOMWrapperWorld::fromWorldId(v8::Isolate* isolate,
                                                          int worldId) {
   if (worldId == MainWorldId)

[peria, 2017/03/08 09:48:19]

isMainWorld()

[nhiroki, 2017/03/08 10:24:53]

isMainWorld() is not available here because fromWorldId() is a static method.

     return &mainWorld();
   return ensureIsolatedWorld(isolate, worldId);
 }
 
 typedef HashMap<int, DOMWrapperWorld*> WorldMap;
 static WorldMap& isolatedWorldMap() {
   ASSERT(isMainThread());
   DEFINE_STATIC_LOCAL(WorldMap, map, ());
   return map;
 }
@@ skipping 74 matching lines @@
   ASSERT(isIsolatedWorldId(worldId));
 
   WorldMap& map = isolatedWorldMap();
   WorldMap::AddResult result = map.insert(worldId, nullptr);
   RefPtr<DOMWrapperWorld> world = result.storedValue->value;
   if (world) {
     ASSERT(world->worldId() == worldId);
     return world.release();
   }
 
-  world = DOMWrapperWorld::create(isolate, worldId);
+  world = adoptRef(new DOMWrapperWorld(isolate, WorldType::Isolated, worldId));
   result.storedValue->value = world.get();
   isolatedWorldCount++;
   return world.release();
 }
 
 typedef HashMap<int, RefPtr<SecurityOrigin>> IsolatedWorldSecurityOriginMap;
 static IsolatedWorldSecurityOriginMap& isolatedWorldSecurityOrigins() {
   ASSERT(isMainThread());
   DEFINE_STATIC_LOCAL(IsolatedWorldSecurityOriginMap, map, ());
   return map;
@@ skipping 87 matching lines @@
   m_domObjectHolders.erase(holderBase);
 }
 
 void DOMWrapperWorld::weakCallbackForDOMObjectHolder(
     const v8::WeakCallbackInfo<DOMObjectHolderBase>& data) {
   DOMObjectHolderBase* holderBase = data.GetParameter();
   holderBase->world()->unregisterDOMObjectHolder(holderBase);
 }
 
 }  // namespace blink