Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: src/heap/concurrent-marking.h

Issue 2735803005: [heap] Start concurrent marking simultaneously with incremental marking. (Closed)
Patch Set: tweak Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/concurrent-marking.h
diff --git a/src/heap/concurrent-marking.h b/src/heap/concurrent-marking.h
index 70842cd230d01c13810026bd5c28f4c6a0aa2c1a..98468996c37bce9a8501861c82efed3f918230d8 100644
--- a/src/heap/concurrent-marking.h
+++ b/src/heap/concurrent-marking.h
@@ -28,11 +28,14 @@ class ConcurrentMarking {
void StartMarkingTask();
void WaitForTaskToComplete();
+ bool IsMarkingInProgress() { return is_task_pending_; }
Hannes Payer (out of office) 2017/03/08 12:58:50 IsInProgress
ulan 2017/03/10 16:45:26 I named it IsTaskPending().
+
private:
class Task;
Heap* heap_;
- base::Semaphore pending_task_;
+ base::Semaphore pending_task_semaphore_;
Michael Lippautz 2017/03/08 19:14:34 super nit (feel free to ignore): We could align na
ulan 2017/03/10 16:45:26 We will probably (re-)start the tasks multiple tim
std::vector<HeapObject*> root_set_;
+ bool is_task_pending_;
};
} // namespace internal
« no previous file with comments | « src/globals.h ('k') | src/heap/concurrent-marking.cc » ('j') | src/heap/concurrent-marking.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698