Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: media/base/win/mf_initializer.cc

Issue 2735783002: Stop assuming anything about result of MFStartup() (Closed)
Patch Set: Mention "N" edition Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/win/mf_initializer.h ('k') | media/capture/video/win/video_capture_device_factory_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/win/mf_initializer.cc
diff --git a/media/base/win/mf_initializer.cc b/media/base/win/mf_initializer.cc
index e27da8fe4dd612f472455f46343150008c68633d..47d78225c915109c4a0bb7a1c90d5b4260434cbf 100644
--- a/media/base/win/mf_initializer.cc
+++ b/media/base/win/mf_initializer.cc
@@ -10,9 +10,11 @@
namespace media {
-void InitializeMediaFoundation() {
- static HRESULT result = MFStartup(MF_VERSION, MFSTARTUP_LITE);
- DCHECK_EQ(result, S_OK);
+bool InitializeMediaFoundation() {
+ static const bool success = MFStartup(MF_VERSION, MFSTARTUP_LITE) == S_OK;
+ DVLOG_IF(1, !success)
+ << "Media Foundation unavailable or it failed to initialize";
+ return success;
}
} // namespace media
« no previous file with comments | « media/base/win/mf_initializer.h ('k') | media/capture/video/win/video_capture_device_factory_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698