Create ResolutionEnqueuer after library loading.

Create ResolutionEnqueuer after library loading.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b9297caadda55812aacc4bb70d9605a72ccec88

[Johnni Winther, 2017-03-06 14:04:58]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-14 05:27:55]

lgtm

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:588: /// already created.
why would it be created before? or is that only in --analyze-all mode? Maybe say
or assert that if that's the reason?

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/li...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/li...
pkg/compiler/lib/src/library_loader.dart:30: import 'enqueue.dart' show
DeferredAction;
consider moving Deferred action under util/deferred_action.dart or something
else to make it clear there is no actual dependency with the enqueuer here.

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/patch_parser.dart (right):

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/patch_parser.dart:366: // [Compiler.onLibrariesLoaded].
I'm assuming that all the libraryLoader's deferred actions fall into a similar
TODO? maybe mark registerDeferredAction with the TODO or even add a @deprecated
to it?

[Johnni Winther, 2017-03-15 12:46:53]

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compiler.dart:588: /// already created.
On 2017/03/14 05:27:55, Siggi Cherem (dart-lang) wrote:
> why would it be created before? or is that only in --analyze-all mode? Maybe
say
> or assert that if that's the reason?

Due to [analyzeUri]. Added to the comment.

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/li...
File pkg/compiler/lib/src/library_loader.dart (right):

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/li...
pkg/compiler/lib/src/library_loader.dart:30: import 'enqueue.dart' show
DeferredAction;
On 2017/03/14 05:27:55, Siggi Cherem (dart-lang) wrote:
> consider moving Deferred action under util/deferred_action.dart or something
> else to make it clear there is no actual dependency with the enqueuer here.

Will do in a later CL.

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/patch_parser.dart (right):

https://codereview.chromium.org/2735763002/diff/20001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/patch_parser.dart:366: // [Compiler.onLibrariesLoaded].
On 2017/03/14 05:27:55, Siggi Cherem (dart-lang) wrote:
> I'm assuming that all the libraryLoader's deferred actions fall into a similar
> TODO? maybe mark registerDeferredAction with the TODO or even add a
@deprecated
> to it?

Add a TODO to [registerDeferredAction].

[Johnni Winther, 2017-03-15 12:47:05]

Description was changed from

==========
Create ResolutionEnqueuer after library loading.
==========

to

==========
Create ResolutionEnqueuer after library loading.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b9297caadda55812aacc4bb70d9605a72ccec88
==========

[Johnni Winther, 2017-03-15 12:47:06]

Committed patchset #3 (id:40001) manually as
4b9297caadda55812aacc4bb70d9605a72ccec88 (presubmit successful).