Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: net/ssl/ssl_config_service.cc

Issue 2735733003: Disable commonName matching for certificates (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/ssl_config.cc ('k') | net/ssl/ssl_config_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_config_service.cc
diff --git a/net/ssl/ssl_config_service.cc b/net/ssl/ssl_config_service.cc
index 2b4388efac58dc7d86c76ef6f74b7602636aa66e..6afef76e86af495c93d2fdafe1843a652550c468 100644
--- a/net/ssl/ssl_config_service.cc
+++ b/net/ssl/ssl_config_service.cc
@@ -83,21 +83,23 @@ void SSLConfigService::NotifySSLConfigChange() {
SSLConfigService::~SSLConfigService() {
}
-void SSLConfigService::ProcessConfigUpdate(const SSLConfig& orig_config,
+void SSLConfigService::ProcessConfigUpdate(const SSLConfig& old_config,
const SSLConfig& new_config) {
bool config_changed =
- std::tie(orig_config.rev_checking_enabled,
- orig_config.rev_checking_required_local_anchors,
- orig_config.sha1_local_anchors_enabled, orig_config.version_min,
- orig_config.version_max, orig_config.disabled_cipher_suites,
- orig_config.channel_id_enabled, orig_config.false_start_enabled,
- orig_config.require_ecdhe) !=
+ std::tie(old_config.rev_checking_enabled,
+ old_config.rev_checking_required_local_anchors,
+ old_config.sha1_local_anchors_enabled,
+ old_config.common_name_fallback_local_anchors_enabled,
+ old_config.version_min, old_config.version_max,
+ old_config.disabled_cipher_suites, old_config.channel_id_enabled,
+ old_config.false_start_enabled, old_config.require_ecdhe) !=
std::tie(new_config.rev_checking_enabled,
new_config.rev_checking_required_local_anchors,
- new_config.sha1_local_anchors_enabled, new_config.version_min,
- new_config.version_max, new_config.disabled_cipher_suites,
- new_config.channel_id_enabled, new_config.false_start_enabled,
- new_config.require_ecdhe);
+ new_config.sha1_local_anchors_enabled,
+ new_config.common_name_fallback_local_anchors_enabled,
+ new_config.version_min, new_config.version_max,
+ new_config.disabled_cipher_suites, new_config.channel_id_enabled,
+ new_config.false_start_enabled, new_config.require_ecdhe);
if (config_changed)
NotifySSLConfigChange();
« no previous file with comments | « net/ssl/ssl_config.cc ('k') | net/ssl/ssl_config_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698