net/spdy/spdy_session.cc - Issue 2735733003: Disable commonName matching for certificates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.cc

Issue 2735733003: Disable commonName matching for certificates (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index 431022624477c12cdb079655abc77cb9b7723f39..07823872e3f1e3691421ddf9601ae7259c5f72c1 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -690,8 +690,7 @@ bool SpdySession::CanPool(TransportSecurityState* transport_security_state,

return false;

}

- bool unused = false;

- if (!ssl_info.cert->VerifyNameMatch(new_hostname, &unused))

+ if (!ssl_info.cert->VerifyNameMatch(new_hostname, false))

return false;

std::string pinning_failure_log;

« no previous file with comments | « net/quic/test_tools/mock_crypto_client_stream.cc ('k') | net/ssl/ssl_config.h » ('j') | no next file with comments »