net/cert/cert_verify_proc_mac.cc - Issue 2735733003: Disable commonName matching for certificates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_mac.cc

Issue 2735733003: Disable commonName matching for certificates (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_verify_proc_mac.cc

diff --git a/net/cert/cert_verify_proc_mac.cc b/net/cert/cert_verify_proc_mac.cc

index 987eed236e46f14d2f9066ebd9a0ecc87c6d2a57..234d95997494cd86d831c4f408b429756515beab 100644

--- a/net/cert/cert_verify_proc_mac.cc

+++ b/net/cert/cert_verify_proc_mac.cc

@@ -988,8 +988,8 @@ int VerifyWithGivenFlags(X509Certificate* cert,

break;

}

- // Perform hostname verification independent of SecTrustEvaluate. In order to

- // do so, mask off any reported name errors first.

+ // Hostname validation is handled by CertVerifyProc, so mask off any errors

+ // that SecTrustEvaluate may have set, as its results are not used.

verify_result->cert_status &= ~CERT_STATUS_COMMON_NAME_INVALID;

// TODO(wtc): Suppress CERT_STATUS_NO_REVOCATION_MECHANISM for now to be

« no previous file with comments | « net/cert/cert_verify_proc_ios.cc ('k') | net/cert/cert_verify_proc_openssl.cc » ('j') | no next file with comments »