Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

Issue 2735703005: [LayoutNG] Out-of-flow positioned objects in inline (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
index 6dcb0ef920414077a1ce08ed26b9437c28caffd1..4e9fea394c6df49d5f841f85a6d0694a42739fb1 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h
@@ -31,7 +31,7 @@ class CORE_EXPORT NGLineBuilder final {
STACK_ALLOCATED();
public:
- NGLineBuilder(NGInlineNode*, NGConstraintSpace*);
+ NGLineBuilder(NGInlineNode*, NGConstraintSpace*, NGFragmentBuilder*);
const NGConstraintSpace& ConstraintSpace() const {
return *constraint_space_;
@@ -81,7 +81,7 @@ class CORE_EXPORT NGLineBuilder final {
void SetStartOfHangables(unsigned offset);
// Create fragments for all lines created so far.
- void CreateFragments(NGFragmentBuilder*);
+ RefPtr<NGLayoutResult> CreateFragments();
// Copy fragment data of all lines created by this NGLineBuilder to
// LayoutBlockFlow.
@@ -145,6 +145,7 @@ class CORE_EXPORT NGLineBuilder final {
Persistent<NGInlineNode> inline_box_;
NGConstraintSpace* constraint_space_; // Not owned as STACK_ALLOCATED.
+ NGFragmentBuilder* containing_block_builder_;
Vector<RefPtr<NGPhysicalFragment>, 32> fragments_;
Vector<NGLogicalOffset, 32> offsets_;
Vector<LineBoxData, 32> line_box_data_list_;

Powered by Google App Engine
This is Rietveld 408576698