third_party/WebKit/Source/core/html/forms/InputType.cpp - Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/InputType.cpp

Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/InputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/InputType.cpp b/third_party/WebKit/Source/core/html/forms/InputType.cpp

index 5f1485d46fd5c2d60e008ba250e991cc76c7d78f..fd8731fbf506039d5a0a0e2711df2ef4f7fcd88b 100644

--- a/third_party/WebKit/Source/core/html/forms/InputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/InputType.cpp

@@ -510,7 +510,8 @@ void InputType::dispatchSearchEvent() {}

void InputType::setValue(const String& sanitizedValue,

bool valueChanged,

- TextFieldEventBehavior eventBehavior) {

+ TextFieldEventBehavior eventBehavior,

+ TextControlSetValueSelection) {

// This setValue() implementation is used only for ValueMode::kValue except

// TextFieldInputType. That is to say, type=color, type=range, and temporal

// input types.