INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed.

third_party/WebKit/Source/core/html/TextControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 273 matching lines @@
   unsigned newSelectionEnd = selectionEnd();
 
   start = std::min(start, textLength);
   end = std::min(end, textLength);
 
   if (start < end)
     text.replace(start, end - start, replacement);
   else
     text.insert(replacement, start);
 
-  setValue(text, TextFieldEventBehavior::DispatchNoEvent);
+  setValue(text, TextFieldEventBehavior::DispatchNoEvent,
+           TextControlSetValueSelection::kDoNotSet);
 
   if (selectionMode == "select") {
     newSelectionStart = start;
     newSelectionEnd = start + replacementLength;
   } else if (selectionMode == "start") {
     newSelectionStart = newSelectionEnd = start;
   } else if (selectionMode == "end") {
     newSelectionStart = newSelectionEnd = start + replacementLength;
   } else {
     DCHECK_EQ(selectionMode, "preserve");
@@ skipping 98 matching lines @@
     TextFieldSelectionDirection direction) {
   if (openShadowRoot() || !isTextControl())
     return false;
   const unsigned editorValueLength = innerEditorValue().length();
   end = std::min(end, editorValueLength);
   start = std::min(start, end);
   LocalFrame* frame = document().frame();
   if (direction == SelectionHasNoDirection && frame &&
       frame->editor().behavior().shouldConsiderSelectionAsDirectional())
     direction = SelectionHasForwardDirection;
-  cacheSelection(start, end, direction);
+  bool didChange = cacheSelection(start, end, direction);
 
   if (document().focusedElement() != this)
-    return true;
+    return didChange;
 
   HTMLElement* innerEditor = innerEditorElement();
   if (!frame || !innerEditor)
-    return true;
+    return didChange;
 
   Position startPosition = positionForIndex(innerEditor, start);
   Position endPosition =
       start == end ? startPosition : positionForIndex(innerEditor, end);
 
   DCHECK_EQ(start, indexForPosition(innerEditor, startPosition));
   DCHECK_EQ(end, indexForPosition(innerEditor, endPosition));
 
 #if DCHECK_IS_ON()
   // startPosition and endPosition can be null position for example when
   // "-webkit-user-select: none" style attribute is specified.
   if (startPosition.isNotNull() && endPosition.isNotNull()) {
     DCHECK_EQ(startPosition.anchorNode()->ownerShadowHost(), this);
     DCHECK_EQ(endPosition.anchorNode()->ownerShadowHost(), this);
   }
 #endif  // DCHECK_IS_ON()
   frame->selection().setSelection(
       SelectionInDOMTree::Builder()
           .collapse(direction == SelectionHasBackwardDirection ? endPosition
                                                                : startPosition)
           .extend(direction == SelectionHasBackwardDirection ? startPosition
                                                              : endPosition)
           .setIsDirectional(direction != SelectionHasNoDirection)
           .build(),
       FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle |
           FrameSelection::DoNotSetFocus);
-  return true;
+  return didChange;
+}
+
+bool TextControlElement::cacheSelection(unsigned start,
+                                        unsigned end,
+                                        TextFieldSelectionDirection direction) {
+  DCHECK_LE(start, end);
+  bool didChange = m_cachedSelectionStart != start ||
+                   m_cachedSelectionEnd != end ||
+                   m_cachedSelectionDirection != direction;
+  m_cachedSelectionStart = start;
+  m_cachedSelectionEnd = end;
+  m_cachedSelectionDirection = direction;
+  return didChange;
 }
 
 VisiblePosition TextControlElement::visiblePositionForIndex(int index) const {
   if (index <= 0)
     return VisiblePosition::firstPositionInNode(innerEditorElement());
   Position start, end;
   bool selected = Range::selectNodeContents(innerEditorElement(), start, end);
   if (!selected)
     return VisiblePosition();
   CharacterIterator it(start, end);
@@ skipping 267 matching lines @@
     return;
   const SelectionInDOMTree& selection = frame->selection().selectionInDOMTree();
   if (selection.selectionTypeWithLegacyGranularity() != RangeSelection)
     return;
   dispatchEvent(Event::createBubble(EventTypeNames::select));
 }
 
 void TextControlElement::scheduleSelectEvent() {
   Event* event = Event::createBubble(EventTypeNames::select);
   event->setTarget(this);
-  document().enqueueUniqueAnimationFrameEvent(event);
+  document().enqueueAnimationFrameEvent(event);
 }
 
 void TextControlElement::parseAttribute(
     const AttributeModificationParams& params) {
   if (params.name == autocapitalizeAttr)
     UseCounter::count(document(), UseCounter::AutocapitalizeAttribute);
 
   if (params.name == placeholderAttr) {
     updatePlaceholderText();
     updatePlaceholderVisibility();
@@ skipping 189 matching lines @@
 
 void TextControlElement::copyNonAttributePropertiesFromElement(
     const Element& source) {
   const TextControlElement& sourceElement =
       static_cast<const TextControlElement&>(source);
   m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit;
   HTMLFormControlElement::copyNonAttributePropertiesFromElement(source);
 }
 
 }  // namespace blink