third_party/WebKit/LayoutTests/fast/events/select-event-on-input-recursive.html - Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/select-event-on-input-recursive.html

Issue 2735633006: INPUT/TEXTAREA elements: Dispatch 'select' event only if text selection is changed. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/select-event-on-input-and-textarea-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/events/select-event-on-input-recursive-expected.txt » ('j') | third_party/WebKit/Source/core/html/TextControlElement.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <html>

3 <head>

4 <script src="../../resources/js-test.js"></script>

5 </head>

6 <body>

7 <input id="input" value="abcd" />

8 <script>

9 window.jsTestIsAsync = true;

10

11 var eventCalledCount = 0;

12 input.addEventListener("select", function () {

13 eventCalledCount++;

14 input.selectionStart = 1;

15 input.selectionEnd = 3;
yoichio 2017/03/07 09:00:56 This test confirms throttle event queueing. Could This test confirms throttle event queueing. Could you change this to input.value = "foo" input.value = "bar" ? Even that situation, no doubling? tkent 2017/03/07 09:27:34 The throttling itself is unnecessary. I'll update Show quoted text On 2017/03/07 at 09:00:56, yoichio wrote: > This test confirms throttle event queueing. > Could you change this to > input.value = "foo" > input.value = "bar" ? > Even that situation, no doubling? The throttling itself is unnecessary. I'll update the code. tkent 2017/03/07 11:30:08 Done. Uploaded new patch set. Show quoted text On 2017/03/07 at 09:27:34, tkent wrote: > On 2017/03/07 at 09:00:56, yoichio wrote: > > This test confirms throttle event queueing. > > Could you change this to > > input.value = "foo" > > input.value = "bar" ? > > Even that situation, no doubling? > > The throttling itself is unnecessary. I'll update the code. Done. Uploaded new patch set. yoichio 2017/03/08 02:00:36 Do you think this kind of flood is friends of infi Do you think this kind of flood is friends of infinite loop and web authors should check it themselves? https://bugs.chromium.org/p/chromium/issues/detail?id=449470 tkent 2017/03/08 02:05:23 This kind of flood won't happen after this CL beca Show quoted text On 2017/03/08 at 02:00:36, yoichio wrote: > Do you think this kind of flood is friends of infinite > loop and web authors should check it themselves? > https://bugs.chromium.org/p/chromium/issues/detail?id=449470 This kind of flood won't happen after this CL because setting same values to selectionStart/End won't dispatch events. It's the purpose of the spec change.
16 });

17

18 var animationFrameCount = 0;

19 var animation = function () {

20 animationFrameCount++;

21 shouldBeTrue("animationFrameCount == eventCalledCount");

22 if (animationFrameCount == 10)

23 window.finishJSTest();

24 else

25 window.requestAnimationFrame(animation);

26 }

27 window.requestAnimationFrame(animation);

28

29 input.select();

30 </script>

31 </body>

32 </html>

OLD	NEW