third_party/WebKit/Source/core/html/HTMLInputElement.idl - Issue 2735633004: HTML Media Capture: update capture attribute to use string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.idl

Issue 2735633004: HTML Media Capture: update capture attribute to use string. (Closed)

Patch Set: Do not propagate String(capture) outside Blink Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLInputElement.idl

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.idl b/third_party/WebKit/Source/core/html/HTMLInputElement.idl

index da1ac353ab4652680b30671bcc93d3269a31a725..7a9c7bd865efe47d9b6a0dc0c11f8a123fe00177 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.idl

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.idl

@@ -103,9 +103,8 @@ interface HTMLInputElement : HTMLElement {

// HTML Media Capture

// https://w3c.github.io/html-media-capture/#the-capture-attribute

- // TODO(mcasas): |capture| is a |CaptureFacingMode| enum in the spec.

- // https://crbug.com/698853

- [Measure, RuntimeEnabled=MediaCapture, Reflect] attribute boolean capture;

+ // Using DOMString as enum cannot be reflected. https://github.com/w3c/html-media-capture/issues/12

+ [Measure, RuntimeEnabled=MediaCapture, Reflect] attribute DOMString capture;

// Non-standard APIs

[Reflect, MeasureAs=PrefixedDirectoryAttribute] attribute boolean webkitdirectory;