Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.idl

Issue 2735633004: HTML Media Capture: update capture attribute to use string. (Closed)
Patch Set: Fix for android webview Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.idl
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.idl b/third_party/WebKit/Source/core/html/HTMLInputElement.idl
index da1ac353ab4652680b30671bcc93d3269a31a725..24273264c4ae1784267e89bf0abeaa87b97f399c 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.idl
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.idl
@@ -23,6 +23,8 @@
enum SelectionMode { "select", "start", "end", "preserve" };
+enum CaptureFacingMode { "user", "environment" };
mcasas 2017/04/26 19:27:37 nit: please add a link to the Spec relevant Sectio
riju_ 2017/04/27 12:30:20 Done.
+
interface HTMLInputElement : HTMLElement {
[CEReactions, Reflect] attribute DOMString accept;
[CEReactions, Reflect] attribute DOMString alt;
@@ -105,7 +107,7 @@ interface HTMLInputElement : HTMLElement {
// https://w3c.github.io/html-media-capture/#the-capture-attribute
// TODO(mcasas): |capture| is a |CaptureFacingMode| enum in the spec.
// https://crbug.com/698853
mcasas 2017/04/26 19:27:37 Remove the TODO() with the CL.
riju_ 2017/04/27 12:30:19 Done.
- [Measure, RuntimeEnabled=MediaCapture, Reflect] attribute boolean capture;
+ [Measure, RuntimeEnabled=MediaCapture, Reflect] attribute CaptureFacingMode capture;
// Non-standard APIs
[Reflect, MeasureAs=PrefixedDirectoryAttribute] attribute boolean webkitdirectory;

Powered by Google App Engine
This is Rietveld 408576698