Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2735633002: Add MemoryCoordinatorImpl::OnChildVisibilityChanged() (Closed)

Created:
3 years, 9 months ago by bashi
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MemoryCoordinatorImpl::OnChildVisibilityChanged() This is a follow-up CL of crrev.com/2718963002. Use the same logic for child process state initialization and visibility changes. BUG=696844

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -26 lines) Patch
M content/browser/memory/memory_coordinator_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 3 chunks +43 lines, -26 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
bashi
PTAL
3 years, 9 months ago (2017-03-06 01:55:13 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-06 01:57:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735633002/20001
3 years, 9 months ago (2017-03-06 04:28:49 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 04:36:52 UTC) #17
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698