Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2735623002: Parse #operator symbol literals with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 4 chunks +16 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/identifier_context.dart View 3 chunks +7 lines, -4 lines 3 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 9 months ago (2017-03-06 00:15:45 UTC) #1
Paul Berry
lgtm assuming `isContinuation: true` is added back to literalSymbolContinuation. https://codereview.chromium.org/2735623002/diff/1/pkg/front_end/lib/src/fasta/parser/identifier_context.dart File pkg/front_end/lib/src/fasta/parser/identifier_context.dart (right): https://codereview.chromium.org/2735623002/diff/1/pkg/front_end/lib/src/fasta/parser/identifier_context.dart#newcode203 pkg/front_end/lib/src/fasta/parser/identifier_context.dart:203: ...
3 years, 9 months ago (2017-03-06 13:54:06 UTC) #2
scheglov
https://codereview.chromium.org/2735623002/diff/1/pkg/front_end/lib/src/fasta/parser/identifier_context.dart File pkg/front_end/lib/src/fasta/parser/identifier_context.dart (right): https://codereview.chromium.org/2735623002/diff/1/pkg/front_end/lib/src/fasta/parser/identifier_context.dart#newcode208 pkg/front_end/lib/src/fasta/parser/identifier_context.dart:208: const IdentifierContext._('literalSymbolContinuation', inSymbol: true); On 2017/03/06 13:54:06, Paul Berry ...
3 years, 9 months ago (2017-03-06 15:44:55 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as be521515fea2f86ee90600a2673b5933d3ba28db (presubmit successful).
3 years, 9 months ago (2017-03-06 15:47:53 UTC) #5
ahe
3 years, 9 months ago (2017-03-07 15:20:16 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698