Migrate %TypedArray%.prototype.fill to C++

src/elements.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/elements.h"
 
 #include "src/arguments.h"
 #include "src/conversions.h"
 #include "src/factory.h"
 #include "src/isolate-inl.h"
@@ skipping 452 matching lines @@
   } cmp;
   Object** start =
       reinterpret_cast<Object**>(indices->GetFirstElementAddress());
   std::sort(start, start + sort_size, cmp);
   if (write_barrier_mode != SKIP_WRITE_BARRIER) {
     FIXED_ARRAY_ELEMENTS_WRITE_BARRIER(indices->GetIsolate()->heap(), *indices,
                                        0, sort_size);
   }
 }
 
+static Object* FillNumberSlowPath(Isolate* isolate, Handle<JSTypedArray> array,
+                               Handle<Object> obj_value,
+                               uint32_t start, uint32_t end) {
+  const char* kMethodName = "%TypedArray%.prototype.fill";
+  Handle<Object> cast_value;
+  ElementsAccessor* elements = array->GetElementsAccessor();
+
+  for (uint32_t k = start; k < end; ++k) {
+    ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+        isolate, cast_value, Object::ToNumber(obj_value));
+    // TODO(caitp,cbruni): throw on neutered array
+    if (V8_UNLIKELY(array->WasNeutered())) return *array;
+    elements->Set(array, k, *cast_value);
+  }
+  return *array;
+}
+
 static Maybe<bool> IncludesValueSlowPath(Isolate* isolate,
                                          Handle<JSObject> receiver,
                                          Handle<Object> value,
                                          uint32_t start_from, uint32_t length) {
   bool search_for_hole = value->IsUndefined(isolate);
   for (uint32_t k = start_from; k < length; ++k) {
     LookupIterator it(isolate, receiver, k);
     if (!it.IsFound()) {
       if (search_for_hole) return Just(true);
       continue;
@@ skipping 701 matching lines @@
 
   static uint32_t GetCapacityImpl(JSObject* holder,
                                   FixedArrayBase* backing_store) {
     return backing_store->length();
   }
 
   uint32_t GetCapacity(JSObject* holder, FixedArrayBase* backing_store) final {
     return Subclass::GetCapacityImpl(holder, backing_store);
   }
 
+  static Object* FillImpl(Isolate* isolate, Handle<JSObject> receiver,
+                       Handle<Object> obj_value, uint32_t start, uint32_t end) {
+    UNREACHABLE();
+    return *receiver;
+  }
+
+  Object* Fill(Isolate* isolate, Handle<JSObject> receiver,
+            Handle<Object> obj_value, uint32_t start, uint32_t end) {
+    return Subclass::FillImpl(isolate, receiver, obj_value, start, end);
+  }
+
   static Maybe<bool> IncludesValueImpl(Isolate* isolate,
                                        Handle<JSObject> receiver,
                                        Handle<Object> value,
                                        uint32_t start_from, uint32_t length) {
     return IncludesValueSlowPath(isolate, receiver, value, start_from, length);
   }
 
   Maybe<bool> IncludesValue(Isolate* isolate, Handle<JSObject> receiver,
                             Handle<Object> value, uint32_t start_from,
                             uint32_t length) final {
@@ skipping 1604 matching lines @@
         if (get_entries) {
           value = MakeEntryPair(isolate, index, value);
         }
         values_or_entries->set(count++, *value);
       }
     }
     *nof_items = count;
     return Just(true);
   }
 
+  template <typename T, ElementsKind K = Kind>
+  static inline uint8_t MaybeClamp(

[Camillo Bruni, 2017/03/14 09:30:35]

ConvertNumberToUint8Clamped(Handle<Object> obj_value) { ...

[rongjie, 2017/03/14 10:08:48]

Done.

+      Handle<Object> obj_value, JSTypedArray* array,
+      typename std::enable_if<K == UINT8_CLAMPED_ELEMENTS, T>::type = 0) {
+    double value = 0.0;
+    if (obj_value->IsSmi()) {
+      value = Smi::cast(*obj_value)->value();

[Camillo Bruni, 2017/03/14 09:30:36]

Special case directly on Smi and avoid slow double conversion.
 
int value = Smi::cast(*obj_value)->value();
value = std::min<int>(std::max<int>(0, value), 255);
return static_cast<uint8_t>(value);

[rongjie, 2017/03/14 10:08:48]

Done.

+    } else {
+      DCHECK(obj_value->IsHeapNumber());
+      value = HeapNumber::cast(*obj_value)->value();
+    }
+    value = std::min<double>(std::max<double>(0, value), 255);
+    return static_cast<uint8_t>(value);
+  }
+
+  template <typename T, ElementsKind K = Kind>
+  static inline T MaybeClamp(

[Camillo Bruni, 2017/03/14 09:30:36]

static ctype ConvertToNumber(Handle<Object> obj_value) { ...

[rongjie, 2017/03/14 10:08:47]

Done.

+      Handle<Object> obj_value, JSTypedArray* array,
+      typename std::enable_if<K != UINT8_CLAMPED_ELEMENTS, T>::type = 0) {
+    T value = 0;

[Camillo Bruni, 2017/03/14 09:30:36]

ctype value = 0;

[rongjie, 2017/03/14 10:08:48]

Done.

+    if (obj_value->IsSmi()) {
+      value = static_cast<T>(Smi::cast(*obj_value)->value());
+    } else {
+      DCHECK(obj_value->IsHeapNumber());
+      value = static_cast<T>(HeapNumber::cast(*obj_value)->value());
+    }
+    return value;
+  }
+
+  static Object* FillImpl(Isolate* isolate, Handle<JSObject> receiver,
+                       Handle<Object> obj_value, uint32_t start, uint32_t end) {
+    Handle<JSTypedArray> array = Handle<JSTypedArray>::cast(receiver);
+    DCHECK(!array->WasNeutered());
+
+    if (!obj_value->IsNumber()) {
+      return FillNumberSlowPath(isolate, array, obj_value, start, end);
+    }
+
+    ctype value = MaybeClamp<ctype>(obj_value, *array);

[Camillo Bruni, 2017/03/14 09:30:35]

I'm not a too big can of the the additional template machinery, I do find it
rather hard to follow. How about?

ctype value = 0;
if (Kind = UINT8_CLAMPED_ELEMENTS) {
   value = ConvertNumberToUint8Clamped(obj_value)
} else {
   value = ConvertToNumber(obj_value);
}

[rongjie, 2017/03/14 10:08:47]

Done.

I previously tested similar solution but with array->type(), got a lot of
warnings, that was why I resorted to template. Not necessary anymore.

+
+    // Ensure indexes are within array bounds
+    DCHECK_LE(0, start);
+    DCHECK_LE(start, end);
+    DCHECK_LE(end, array->length_value());
+
+    DisallowHeapAllocation no_gc;
+    BackingStore* elements = BackingStore::cast(receiver->elements());
+    ctype* data = static_cast<ctype*>(elements->DataPtr());
+    std::fill(data + start, data + end, value);
+    return *array;
+  }
+
   static Maybe<bool> IncludesValueImpl(Isolate* isolate,
                                        Handle<JSObject> receiver,
                                        Handle<Object> value,
                                        uint32_t start_from, uint32_t length) {
     DCHECK(JSObject::PrototypeHasNoElements(isolate, *receiver));
     DisallowHeapAllocation no_gc;
 
     // TODO(caitp): return Just(false) here when implementing strict throwing on
     // neutered views.
     if (WasNeutered(*receiver)) {
@@ skipping 1037 matching lines @@
     insertion_index += len;
   }
 
   DCHECK_EQ(insertion_index, result_len);
   return result_array;
 }
 
 ElementsAccessor** ElementsAccessor::elements_accessors_ = NULL;
 }  // namespace internal
 }  // namespace v8