Issue 2735473002: VM: Fix product precompiler, it must have FLAG_use_osr set to false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2735473002: VM: Fix product precompiler, it must have FLAG_use_osr set to false. (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)

Modified:
3 years, 9 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix product precompiler, it must have FLAG_use_osr set to false. In reality this flag was set to true which was caught by the new feature checking R=rmacnak@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/890dff146ac4733018c059b36bc4d67c45da3232

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	runtime/vm/clustered_snapshot.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/flag_list.h	View		2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

lgtm This also has the effect of disabling osr when dart_bootstrap is being used as ...

3 years, 9 months ago (2017-03-03 22:37:07 UTC) #2

Vyacheslav Egorov (Google)

3 years, 9 months ago (2017-03-03 22:41:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
890dff146ac4733018c059b36bc4d67c45da3232 (presubmit successful).