Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: components/metrics/test_metrics_service_client.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/test_metrics_service_client.cc
diff --git a/components/metrics/test_metrics_service_client.cc b/components/metrics/test_metrics_service_client.cc
index b68bef847f500fd0fc2d42c66c4bbd1c6c6dc6d2..254ac81838f1601dec898b900b2d1e02d311a78d 100644
--- a/components/metrics/test_metrics_service_client.cc
+++ b/components/metrics/test_metrics_service_client.cc
@@ -65,12 +65,11 @@ void TestMetricsServiceClient::CollectFinalMetricsForLog(
}
std::unique_ptr<MetricsLogUploader> TestMetricsServiceClient::CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ const base::StringPiece& server_url,
+ const base::StringPiece& mime_type,
MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) {
- uploader_ = new TestMetricsLogUploader(server_url, mime_type, service_type,
- on_upload_complete);
+ uploader_ = new TestMetricsLogUploader(on_upload_complete);
return std::unique_ptr<MetricsLogUploader>(uploader_);
}

Powered by Google App Engine
This is Rietveld 408576698