Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: components/metrics/test_metrics_log_uploader.h

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/test_metrics_log_uploader.h
diff --git a/components/metrics/test_metrics_log_uploader.h b/components/metrics/test_metrics_log_uploader.h
index 196370a4198993e969d6b835647e316bab24c3c5..e887d2deb658ed4434411a95b21114fb9a7082f4 100644
--- a/components/metrics/test_metrics_log_uploader.h
+++ b/components/metrics/test_metrics_log_uploader.h
@@ -11,11 +11,8 @@ namespace metrics {
class TestMetricsLogUploader : public MetricsLogUploader {
public:
- TestMetricsLogUploader(const std::string& server_url,
- const std::string& mime_type,
- MetricsLogUploader::MetricServiceType service_type,
- const base::Callback<void(int)>& on_upload_complete);
- ~TestMetricsLogUploader() override;
+ TestMetricsLogUploader(const base::Callback<void(int)>& on_upload_complete);
Alexei Svitkine (slow) 2017/03/06 21:07:46 explicit
Steven Holte 2017/03/06 21:22:11 Done.
+ ~TestMetricsLogUploader();
// Mark the current upload complete with the given response code.
void CompleteUpload(int response_code);
@@ -28,6 +25,7 @@ class TestMetricsLogUploader : public MetricsLogUploader {
void UploadLog(const std::string& compressed_log_data,
const std::string& log_hash) override;
+ const base::Callback<void(int)> on_upload_complete_;
bool is_uploading_;
DISALLOW_COPY_AND_ASSIGN(TestMetricsLogUploader);

Powered by Google App Engine
This is Rietveld 408576698