Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: android_webview/native/aw_metrics_service_client_impl.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_metrics_service_client_impl.cc
diff --git a/android_webview/native/aw_metrics_service_client_impl.cc b/android_webview/native/aw_metrics_service_client_impl.cc
index d1ab432a32e5bf369f02631273baf45fbe475704..8b711b1c991f103c122ab05a3c2dbcd29bcde55f 100644
--- a/android_webview/native/aw_metrics_service_client_impl.cc
+++ b/android_webview/native/aw_metrics_service_client_impl.cc
@@ -203,8 +203,8 @@ void AwMetricsServiceClientImpl::CollectFinalMetricsForLog(
std::unique_ptr<metrics::MetricsLogUploader>
AwMetricsServiceClientImpl::CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ const base::StringPiece& server_url,
+ const base::StringPiece& mime_type,
metrics::MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) {
return std::unique_ptr<::metrics::MetricsLogUploader>(

Powered by Google App Engine
This is Rietveld 408576698