Add FilePath setter/getter to pref service....

Add FilePath setter/getter to pref service. Change callers to use it rather than the string methods.

Update the pref service unit test and enable it on linux.

Also switch over some wstrings to filepaths where appropriate.

BUG=8154
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10844

[Evan Stade, 2009-03-02 22:42:45]

this is only step 1. Step 2 is to actually update the callers (including unit
tests).

[tony, 2009-03-02 22:57:56]

http://codereview.chromium.org/27354/diff/1/5
File chrome/common/pref_service.h (right):

http://codereview.chromium.org/27354/diff/1/5#newcode156
Line 156: void SetString(const wchar_t* path, const std::wstring& value);
Shouldn't there be a SetFilePath(const wchar_t* path, const FilePath& value);
here?

[Evan Stade, 2009-03-02 23:07:07]

http://codereview.chromium.org/27354/diff/1/5
File chrome/common/pref_service.h (right):

http://codereview.chromium.org/27354/diff/1/5#newcode156
Line 156: void SetString(const wchar_t* path, const std::wstring& value);
On 2009/03/02 22:57:57, tony wrote:
> Shouldn't there be a SetFilePath(const wchar_t* path, const FilePath& value);
> here?

yea

[Evan Stade, 2009-03-02 23:13:38]

ah nevermind this isn't ready, gotta port some unit tests

[Evan Stade, 2009-03-03 19:20:27]

ok, this really doesn't want to upload. The download raw patch set link works
though. And really, who needs color coding?

I had to port a bunch more unit tests (it was definitely a mistake to convert
the PrefService constructor to to filepaths in this same patch).