src/ia32/assembler-ia32.cc - Issue 2735363002: [ia32] Fix invalid DCHECK on cmpw with immediate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32.cc

Issue 2735363002: [ia32] Fix invalid DCHECK on cmpw with immediate. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/assembler-ia32.cc

diff --git a/src/ia32/assembler-ia32.cc b/src/ia32/assembler-ia32.cc

index 2977e9fc3a11479794d06b097032ef8772d82429..e22688334da178c9132934bbb70f761954c53d09 100644

--- a/src/ia32/assembler-ia32.cc

+++ b/src/ia32/assembler-ia32.cc

@@ -841,7 +841,7 @@ void Assembler::cmpb(Register reg, const Operand& op) {

void Assembler::cmpw(const Operand& op, Immediate imm16) {

- DCHECK(imm16.is_int16());

+ DCHECK(imm16.is_int16() || imm16.is_uint16());

EnsureSpace ensure_space(this);

EMIT(0x66);

EMIT(0x81);

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-6063.js » ('j') | no next file with comments »