Flag covering HID-detection OOBE screen removed.

Flag covering HID-detection OOBE screen removed.

BUG=127016
TBR=rkc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276656

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277835

[Nikita (slow), 2014-05-13 12:33:02]

You may as well add another flag: --disable-hid-detection-on-oobe in case we
decide to disable this feature quickly.

https://codereview.chromium.org/273533004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css
(right):

https://codereview.chromium.org/273533004/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css:56: left:
-28px;
RTL?

[merkulova, 2014-05-14 14:22:08]

https://codereview.chromium.org/273533004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css
(right):

https://codereview.chromium.org/273533004/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css:56: left:
-28px;
On 2014/05/13 12:33:02, Nikita Kostylev wrote:
> RTL?

Done.

[Nikita (slow), 2014-05-15 13:24:53]

lgtm

[commit-bot: I haz the power, 2014-05-15 13:25:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/40001

[commit-bot: I haz the power, 2014-05-15 14:52:20]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-15 15:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-15 15:50:11]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[merkulova, 2014-05-21 11:53:48]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:56:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/60001

[commit-bot: I haz the power, 2014-05-22 05:39:20]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-22 05:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 05:44:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[merkulova, 2014-05-22 08:52:18]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-05-22 08:55:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/100001

[commit-bot: I haz the power, 2014-05-22 14:58:31]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-22 16:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:04:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[merkulova, 2014-05-23 07:34:20]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-05-23 07:35:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/100001

[commit-bot: I haz the power, 2014-05-23 08:47:33]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-23 09:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 09:57:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[merkulova, 2014-05-30 15:44:09]

Current version fails on DemoAppLauncher.* tests (timed out)

+rkc@ for browser tests and ideas for proper patching.

[merkulova, 2014-06-09 13:50:26]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-09 13:51:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/120001

[commit-bot: I haz the power, 2014-06-09 14:11:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/14439)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/17555)

[merkulova, 2014-06-09 14:12:30]

The CQ bit was unchecked by merkulova@chromium.org

[merkulova, 2014-06-09 14:12:35]

The CQ bit was checked by merkulova@chromium.org

[merkulova, 2014-06-09 14:12:57]

The CQ bit was unchecked by merkulova@chromium.org

[merkulova, 2014-06-09 14:15:56]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-09 14:16:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/160001

[commit-bot: I haz the power, 2014-06-09 22:55:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/14566)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/17681)

[commit-bot: I haz the power, 2014-06-09 23:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-09 23:01:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Nikita (slow), 2014-06-11 12:51:21]

https://codereview.chromium.org/273533004/diff/220001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/demo_mode_detector.cc (right):

https://codereview.chromium.org/273533004/diff/220001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/demo_mode_detector.cc:18: const int
kDerelectIdleTimeoutSeconds = 5 * 60;  // 5 minutes.
nit: Align comments.

https://codereview.chromium.org/273533004/diff/240001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc
(right):

https://codereview.chromium.org/273533004/diff/240001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc:441:
core_oobe_actor_->InitDemoModeDetection();
nit: As discussed, please use these methods in pairs:
Init/Stop

[merkulova, 2014-06-11 15:46:44]

https://codereview.chromium.org/273533004/diff/240001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc
(right):

https://codereview.chromium.org/273533004/diff/240001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc:441:
core_oobe_actor_->InitDemoModeDetection();
On 2014/06/11 12:51:21, Nikita Kostylev wrote:
> nit: As discussed, please use these methods in pairs:
> Init/Stop

Done.

[merkulova, 2014-06-11 15:48:37]

The CQ bit was checked by merkulova@chromium.org

[merkulova, 2014-06-11 15:49:17]

The CQ bit was unchecked by merkulova@chromium.org

[Nikita (slow), 2014-06-11 15:49:49]

lgtm

https://codereview.chromium.org/273533004/diff/280001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/demo_mode_detector.h (right):

https://codereview.chromium.org/273533004/diff/280001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/demo_mode_detector.h:51: bool
demo_launched;
nit: demo_launched_

[merkulova, 2014-06-11 15:51:52]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-11 15:54:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/300001

[commit-bot: I haz the power, 2014-06-11 21:30:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:33:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:33:54]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[merkulova, 2014-06-12 09:22:50]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-12 09:24:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/300001

[commit-bot: I haz the power, 2014-06-12 13:16:30]

Change committed as 276656

[Nikita (slow), 2014-06-17 15:21:41]

lgtm

[merkulova, 2014-06-17 15:33:27]

The CQ bit was unchecked by merkulova@chromium.org

[merkulova, 2014-06-17 15:52:01]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-17 15:52:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/273533004/360001

[commit-bot: I haz the power, 2014-06-17 19:20:26]

Change committed as 277835