Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 27353003: Adds the ability to skip includes. (Closed)

Created:
7 years, 2 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Adds the ability to skip includes. Checks for a flag set in the toplevel dictionary of a file, and if its set, the includes for this file will be skipped. In the Chrome build, this allows us to write final .gyp files with all flags preprocessed and to not modify anything based on common.gypi. This reverts r1723 (write link deps file) since this new GN integration replaces it. BUG=307571

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M pylib/gyp/generator/ninja.py View 5 chunks +2 lines, -18 lines 0 comments Download
M pylib/gyp/input.py View 1 chunk +13 lines, -11 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
brettw
The GN-side change is https://codereview.chromium.org/26561005/
7 years, 2 months ago (2013-10-15 17:03:00 UTC) #1
Nico
https://codereview.chromium.org/27353003/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://codereview.chromium.org/27353003/diff/1/pylib/gyp/input.py#newcode233 pylib/gyp/input.py:233: not build_file_data['skip_includes']): This maybe doesn't have to be so ...
7 years, 2 months ago (2013-10-15 17:12:50 UTC) #2
brettw
https://codereview.chromium.org/27353003/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://codereview.chromium.org/27353003/diff/1/pylib/gyp/input.py#newcode233 pylib/gyp/input.py:233: not build_file_data['skip_includes']): GYP files that depend on this would ...
7 years, 2 months ago (2013-10-15 17:20:02 UTC) #3
Nico
7 years, 2 months ago (2013-10-15 18:20:59 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698