Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 273523008: SelectorChecker::parentElement should walk up to ShadowHost only if an element is in a shadow tree … (Closed)

Created:
6 years, 7 months ago by tasak
Modified:
6 years, 7 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

SelectorChecker::parentElement should walk up to ShadowHost only if an element is in a shadow tree hosted by the ShadowHost and scope is the ShadowHost. :host can only match shadow host. :host depends on context.scope with ScopeIsShadowHost behavior. So only if context.scope is shadow host and context.element's shadow host is context.scope, we need to check the shadow host. BUG=370303 TEST=fast/dom/shadow/style-with-cat.html, fast/dom/shadow/style-with-hat.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M LayoutTests/fast/dom/shadow/style-with-cat.html View 1 chunk +21 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-cat-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-hat.html View 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-hat-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tasak
Would you review this CL?
6 years, 7 months ago (2014-05-08 10:47:14 UTC) #1
dglazkov
lgtm. We really ought to look at rewriting this logic. All of these conditions are ...
6 years, 7 months ago (2014-05-08 19:21:48 UTC) #2
tasak
Thank you for reviewing.
6 years, 7 months ago (2014-05-09 02:13:29 UTC) #3
tasak
The CQ bit was checked by tasak@google.com
6 years, 7 months ago (2014-05-09 02:13:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/273523008/1
6 years, 7 months ago (2014-05-09 02:15:38 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 02:30:52 UTC) #6
Message was sent while issue was closed.
Change committed as 173703

Powered by Google App Engine
This is Rietveld 408576698