Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 273523007: Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of threa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: fix android Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/callback_list.h ('K') | « chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | content/browser/geolocation/geolocation_dispatcher_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
===================================================================
--- chrome/browser/guest_view/web_view/web_view_guest.cc (revision 269041)
+++ chrome/browser/guest_view/web_view/web_view_guest.cc (working copy)
@@ -591,8 +591,7 @@
DCHECK(geolocation_context);
geolocation_context->RequestGeolocationPermission(
- embedder_web_contents()->GetRenderProcessHost()->GetID(),
- embedder_web_contents()->GetRoutingID(),
+ embedder_web_contents(),
// The geolocation permission request here is not initiated
// through WebGeolocationPermissionRequest. We are only interested
// in the fact whether the embedder/app has geolocation
« base/callback_list.h ('K') | « chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | content/browser/geolocation/geolocation_dispatcher_host.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698