chrome/browser/extensions/api/location/location_manager.h - Issue 273523007: Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of threa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/location/location_manager.h

Issue 273523007: Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of threa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: fix android Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/callback_list.h ('K') | « chrome/browser/chromeos/policy/device_status_collector.cc ('k') | chrome/browser/extensions/api/location/location_manager.cc » ('j') | content/browser/geolocation/geolocation_dispatcher_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/location/location_manager.h

===================================================================

--- chrome/browser/extensions/api/location/location_manager.h (revision 269041)

+++ chrome/browser/extensions/api/location/location_manager.h (working copy)

@@ -8,7 +8,6 @@

#include <map>

#include <string>

-#include "base/memory/weak_ptr.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "extensions/browser/browser_context_keyed_api_factory.h"

@@ -35,8 +34,7 @@

// Profile's manager of all location watch requests created by chrome.location

// API. Lives in the UI thread.

class LocationManager : public BrowserContextKeyedAPI,

- public content::NotificationObserver,

- public base::SupportsWeakPtr<LocationManager> {

+ public content::NotificationObserver {

public:

explicit LocationManager(content::BrowserContext* context);

virtual ~LocationManager();