content/browser/renderer_host/render_process_host_impl.cc - Issue 273523007: Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of threa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 273523007: Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of threa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: sync Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_process_host_impl.cc

===================================================================

--- content/browser/renderer_host/render_process_host_impl.cc (revision 269778)

+++ content/browser/renderer_host/render_process_host_impl.cc (working copy)

@@ -411,7 +411,6 @@

delayed_cleanup_needed_(false),

within_process_died_observer_(false),

power_monitor_broadcaster_(this),

- geolocation_dispatcher_host_(NULL),

screen_orientation_dispatcher_host_(NULL),

worker_ref_count_(0),

weak_factory_(this) {

@@ -705,9 +704,6 @@

storage_partition_impl_->GetIndexedDBContext(),

ChromeBlobStorageContext::GetFor(browser_context)));

- geolocation_dispatcher_host_ = new GeolocationDispatcherHost(

- GetID(), browser_context->GetGeolocationPermissionContext());

- AddFilter(geolocation_dispatcher_host_);

gpu_message_filter_ = new GpuMessageFilter(GetID(), widget_helper_.get());

AddFilter(gpu_message_filter_);

#if defined(ENABLE_WEBRTC)

@@ -1452,7 +1448,6 @@

channel_.reset();

gpu_message_filter_ = NULL;

message_port_message_filter_ = NULL;

- geolocation_dispatcher_host_ = NULL;

screen_orientation_dispatcher_host_ = NULL;

// Remove ourself from the list of renderer processes so that we can't be

@@ -1840,7 +1835,6 @@

channel_.reset();

gpu_message_filter_ = NULL;

message_port_message_filter_ = NULL;

- geolocation_dispatcher_host_ = NULL;

screen_orientation_dispatcher_host_ = NULL;

IDMap<IPC::Listener>::iterator iter(&listeners_);