Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of threa…

content/common/geolocation_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for geolocation.
 // Multiply-included message file, hence no include guard.
 
 #include "content/public/common/geoposition.h"
 #include "ipc/ipc_message_macros.h"
 #include "url/gurl.h"
@@ skipping 24 matching lines @@
                     bool /* is_allowed */)
 
 // Sent after GeolocationHostMsg_StartUpdating iff the user has granted
 // permission and we have a position available or an error occurs (such as
 // permission denied, position unavailable, etc.)
 IPC_MESSAGE_ROUTED1(GeolocationMsg_PositionUpdated,
                     content::Geoposition /* geoposition */)
 
 // Messages sent from the renderer to the browser.
 
-// The |render_view_id| and |bridge_id| representing |host| is requesting
-// permission to access geolocation position.
-// This will be replied by GeolocationMsg_PermissionSet.
-IPC_MESSAGE_CONTROL4(GeolocationHostMsg_RequestPermission,
-                     int /* render_view_id */,
+// The |bridge_id| representing |host| is requesting permission to access

[Michael van Ouwerkerk, 2014/05/08 13:20:02]

Judging from the comment for the next message: s/host/GURL/

[jam, 2014/05/08 15:04:58]

I'm guessing that comment was meant to refer to the url as the host; and wasn't
referring to the parameter type (since we don't have a "Host" class). since this
is the existing comment, and to me it's not unclear, let's leave as is.

+// geolocation position. This will be replied by GeolocationMsg_PermissionSet.
+IPC_MESSAGE_ROUTED3(GeolocationHostMsg_RequestPermission,
                      int /* bridge_id */,
                      GURL /* GURL of the frame requesting geolocation */,
                      bool /* user_gesture */)
 
-// The |render_view_id| and |bridge_id| representing |GURL| is cancelling its
-// previous permission request to access geolocation position.
-IPC_MESSAGE_CONTROL3(GeolocationHostMsg_CancelPermissionRequest,
-                     int /* render_view_id */,
-                     int /* bridge_id */,
-                     GURL /* GURL of the frame */)
+// The |bridge_id| representing |GURL| is cancelling its previous permission
+// request to access geolocation position.
+IPC_MESSAGE_ROUTED2(GeolocationHostMsg_CancelPermissionRequest,
+                    int /* bridge_id */,
+                    GURL /* GURL of the frame */)
 
-// The |render_view_id| requests Geolocation service to start updating.
+// The render view requests the Geolocation service to start updating.
 // This is an asynchronous call, and the browser process may eventually reply
 // with the updated geoposition, or an error (access denied, location
 // unavailable, etc.)
-IPC_MESSAGE_CONTROL3(GeolocationHostMsg_StartUpdating,
-                     int /* render_view_id */,
+IPC_MESSAGE_ROUTED2(GeolocationHostMsg_StartUpdating,
                      GURL /* GURL of the frame requesting geolocation */,
                      bool /* enable_high_accuracy */)
 
-// The |render_view_id| requests Geolocation service to stop updating.
+// The  render view requests Geolocation service to stop updating.
 // Note that the geolocation service may continue to fetch geolocation data
 // for other origins.
-IPC_MESSAGE_CONTROL1(GeolocationHostMsg_StopUpdating,
-                     int /* render_view_id */)
+IPC_MESSAGE_ROUTED0(GeolocationHostMsg_StopUpdating)