Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Issue 2735193002: Issue 25733. Built-in itentifiers are not permitted as prefixes. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 4 chunks +23 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-07 17:39:47 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-07 18:14:30 UTC) #2
scheglov
3 years, 9 months ago (2017-03-07 18:16:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
571aae42b87cd14da5a8d0b5ec0f7f776f14534a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698