content/browser/web_contents/web_contents_impl.cc - Issue 2735183003: PlzNavigate: stop navigations when opening a document for write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2735183003: PlzNavigate: stop navigations when opening a document for write (Closed)

Patch Set: Addressed commemts Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index b1653692c42112e5fb0c051641545d6f62903c23..a0cd5e03539dda1dd0f9636c17a8b6d2db49db40 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -556,7 +556,7 @@ WebContentsImpl::~WebContentsImpl() {

// PlzNavigate: clear up state specific to browser-side navigation.

if (IsBrowserSideNavigationEnabled()) {

// Do not update state as the WebContents is being destroyed.

- frame_tree_.root()->ResetNavigationRequest(true);

+ frame_tree_.root()->ResetNavigationRequest(true, true);

if (root->speculative_frame_host()) {

root->speculative_frame_host()->SetRenderFrameCreated(false);

root->speculative_frame_host()->SetNavigationHandle(