content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 2735183003: PlzNavigate: stop navigations when opening a document for write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 2735183003: PlzNavigate: stop navigations when opening a document for write (Closed)

Patch Set: Addressed commemts Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index f01cc7aa831af82daefb1c98162e514d4c379290..9db04746d2215b92d3f7ac5df147a4793ea9b1fa 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -3652,7 +3652,7 @@ TEST_F(NavigationControllerTest, ShowBrowserURLAfterFailUntilModified) {

// stop or a new navigation from the user. The URL should remain visible.

if (IsBrowserSideNavigationEnabled()) {

static_cast<NavigatorImpl*>(main_test_rfh()->frame_tree_node()->navigator())

- ->CancelNavigation(main_test_rfh()->frame_tree_node());

+ ->CancelNavigation(main_test_rfh()->frame_tree_node(), true);

} else {

FrameHostMsg_DidFailProvisionalLoadWithError_Params params;

params.error_code = net::ERR_ABORTED;