PlzNavigate: stop navigations when opening a document for write

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 572 matching lines @@
                    blink::WebHistoryCommitType commit_type) override;
   void didFinishLoad(blink::WebLocalFrame* frame) override;
   void didNavigateWithinPage(blink::WebLocalFrame* frame,
                              const blink::WebHistoryItem& item,
                              blink::WebHistoryCommitType commit_type,
                              bool content_initiated) override;
   void didUpdateCurrentHistoryItem() override;
   void didChangeThemeColor() override;
   void dispatchLoad() override;
   blink::WebEffectiveConnectionType getEffectiveConnectionType() override;
+  void abortClientNavigation() override;
   void didChangeSelection(bool is_empty_selection) override;
   bool handleCurrentKeyboardEvent() override;
   blink::WebColorChooser* createColorChooser(
       blink::WebColorChooserClient* client,
       const blink::WebColor& initial_color,
       const blink::WebVector<blink::WebColorSuggestion>& suggestions) override;
   void runModalAlertDialog(const blink::WebString& message) override;
   bool runModalConfirmDialog(const blink::WebString& message) override;
   bool runModalPromptDialog(const blink::WebString& message,
                             const blink::WebString& default_value,
@@ skipping 286 matching lines @@
       const FrameMsg_TextTrackSettings_Params& params);
   void OnPostMessageEvent(const FrameMsg_PostMessage_Params& params);
   void OnCommitNavigation(const ResourceResponseHead& response,
                           const GURL& stream_url,
                           const CommonNavigationParams& common_params,
                           const RequestNavigationParams& request_params);
   void OnFailedNavigation(const CommonNavigationParams& common_params,
                           const RequestNavigationParams& request_params,
                           bool has_stale_copy_in_cache,
                           int error_code);
+  void OnDroppedNavigation(int navigation_id);
   void OnGetSavableResourceLinks();
   void OnGetSerializedHtmlWithLocalLinks(
       const std::map<GURL, base::FilePath>& url_to_local_path,
       const std::map<int, base::FilePath>& frame_routing_id_to_local_path);
   void OnSerializeAsMHTML(const FrameMsg_SerializeAsMHTML_Params& params);
   void OnFind(int request_id,
               const base::string16& search_text,
               const blink::WebFindOptions& options);
   void OnClearActiveFindMatch();
   void OnStopFinding(StopFindAction action);
@@ skipping 508 matching lines @@
           client_redirect(info.isClientRedirect),
           cache_disabled(info.isCacheDisabled),
           form(info.form) {}
   };
 
   // PlzNavigate: Contains information about a pending navigation to be sent to
   // the browser. This state is allocated in decidePolicyForNavigation() and
   // is used and released in didStartProvisionalLoad().
   std::unique_ptr<PendingNavigationInfo> pending_navigation_info_;
 
+  // PlzNavigate
+  // An id to identify the last navigation sent to the browser.
+  int navigation_id_ = 0;

[nasko, 2017/03/16 21:23:14]

I'd like to hear what Charlie thinks about this approach. We used to have
page_id, which we removed and this kinda feels like this.

nit: unsigned?

[clamy, 2017/03/17 15:19:11]

TBH I'm not super happy about introducing an id, but I don't really see a better
way. The only thing is that it's absolutely not used on the browser side, and is
really meant for book keeping in the renderer process. When we switch to mojo, I
hope that with the services we can have a more reliable way of knowing that the
request we asked the browser to do was cancelled, and this id can go away.

For making the int unsigned, I'm going to transmit it as an int (given that -1
is a possible value), and I'd rather avoid the unsigned/signed conversion if
possible.

+
   base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_