PlzNavigate: stop navigations when opening a document for write

content/browser/frame_host/frame_tree_node.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 #define CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 243 matching lines @@
   // NavigationRequest of this frame. This corresponds to the start of a new
   // navigation. If there was an ongoing navigation request before calling this
   // function, it is canceled. |navigation_request| should not be null.
   void CreatedNavigationRequest(
       std::unique_ptr<NavigationRequest> navigation_request);
 
   // PlzNavigate
   // Resets the current navigation request. If |keep_state| is true, any state
   // created by the NavigationRequest (e.g. speculative RenderFrameHost,
   // loading state) will not be reset by the function.
-  void ResetNavigationRequest(bool keep_state);
+  // If |keep_state| is false, teh request is renderer-initiated and

[Charlie Reis, 2017/03/22 23:54:41]

nit: s/teh/the/

nit: ..."renderer-initiated. If"
(That is, I think it might be clearer to split the sentences.  Or are the two
parameters somehow dependent?)

[clamy, 2017/03/23 13:17:52]

Done
Yes they all need to be present. I've replaced the first comma by an "and" to
make it clearer.

+  // |inform_renderer| is true, an IPC will be sent to the renderer process to
+  // inform it that the navigation it requested was cancelled.
+  void ResetNavigationRequest(bool keep_state, bool inform_renderer);
 
   // Returns true if this node is in a state where the loading progress is being
   // tracked.
   bool has_started_loading() const;
 
   // Resets this node's loading progress.
   void reset_loading_progress();
 
   // A RenderFrameHost in this node started loading.
   // |to_different_document| will be true unless the load is a fragment
@@ skipping 125 matching lines @@
   // browser process activities to this node (when possible).  It is unrelated
   // to the core logic of FrameTreeNode.
   FrameTreeNodeBlameContext blame_context_;
 
   DISALLOW_COPY_AND_ASSIGN(FrameTreeNode);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_FRAME_TREE_NODE_H_