PlzNavigate: stop navigations when opening a document for write

content/browser/frame_host/frame_tree_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree_node.h"
 
 #include <queue>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 366 matching lines @@
   // notifications for Javascript URLS.
   DCHECK(!navigation_request->common_params().url.SchemeIs(
       url::kJavaScriptScheme));
 
   bool was_previously_loading = frame_tree()->IsLoading();
 
   // There's no need to reset the state: there's still an ongoing load, and the
   // RenderFrameHostManager will take care of updates to the speculative
   // RenderFrameHost in DidCreateNavigationRequest below.
   if (was_previously_loading)
-    ResetNavigationRequest(true);
+    ResetNavigationRequest(true, true);
 
   navigation_request_ = std::move(navigation_request);
   render_manager()->DidCreateNavigationRequest(navigation_request_.get());
 
   bool to_different_document = !FrameMsg_Navigate_Type::IsSameDocument(
       navigation_request_->common_params().navigation_type);
 
   DidStartLoading(to_different_document, was_previously_loading);
 }
 
-void FrameTreeNode::ResetNavigationRequest(bool keep_state) {
+void FrameTreeNode::ResetNavigationRequest(bool keep_state,
+                                           bool inform_renderer) {
   CHECK(IsBrowserSideNavigationEnabled());
   if (!navigation_request_)
     return;
   bool was_renderer_initiated = !navigation_request_->browser_initiated();
   NavigationRequest::AssociatedSiteInstanceType site_instance_type =
       navigation_request_->associated_site_instance_type();
   navigation_request_.reset();
 
   if (keep_state)
     return;
 
   // The RenderFrameHostManager should clean up any speculative RenderFrameHost
   // it created for the navigation. Also register that the load stopped.
   DidStopLoading();
   render_manager_.CleanUpNavigation();
 
   // When reusing the same SiteInstance, a pending WebUI may have been created
   // on behalf of the navigation in the current RenderFrameHost. Clear it.
   if (site_instance_type ==
       NavigationRequest::AssociatedSiteInstanceType::CURRENT) {
     current_frame_host()->ClearPendingWebUI();
   }
 
   // If the navigation is renderer-initiated, the renderer should also be
   // informed that the navigation stopped.

[Charlie Reis, 2017/03/22 23:54:41]

nit: Update comment, maybe giving an example of why inform_renderer would be
false.

[clamy, 2017/03/23 13:17:52]

Done.

-  if (was_renderer_initiated) {
+  if (was_renderer_initiated && inform_renderer) {
     current_frame_host()->Send(
         new FrameMsg_Stop(current_frame_host()->GetRoutingID()));
   }
 
 }
 
 bool FrameTreeNode::has_started_loading() const {
   return loading_progress_ != kLoadingProgressNotStarted;
 }
 
@@ skipping 58 matching lines @@
   loading_progress_ = load_progress;
   frame_tree_->UpdateLoadProgress();
 }
 
 bool FrameTreeNode::StopLoading() {
   if (IsBrowserSideNavigationEnabled()) {
     if (navigation_request_) {
       navigation_request_->navigation_handle()->set_net_error_code(
           net::ERR_ABORTED);
     }
-    ResetNavigationRequest(false);
+    ResetNavigationRequest(false, true);
   }
 
   // TODO(nasko): see if child frames should send IPCs in site-per-process
   // mode.
   if (!IsMainFrame())
     return true;
 
   render_manager_.Stop();
   return true;
 }
@@ skipping 44 matching lines @@
       }
       return parent_->child_at(i + relative_offset);
     }
   }
 
   NOTREACHED() << "FrameTreeNode not found in its parent's children.";
   return nullptr;
 }
 
 }  // namespace content