PlzNavigate: stop navigations when opening a document for write

content/browser/frame_host/frame_tree_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree_node.h"
 
 #include <queue>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 408 matching lines @@
   // on behalf of the navigation in the current RenderFrameHost. Clear it.
   if (site_instance_type ==
       NavigationRequest::AssociatedSiteInstanceType::CURRENT) {
     current_frame_host()->ClearPendingWebUI();
   }
 
   // If the navigation is renderer-initiated, the renderer should also be
   // informed that the navigation stopped.
   if (was_renderer_initiated) {
     current_frame_host()->Send(
-        new FrameMsg_Stop(current_frame_host()->GetRoutingID()));
+        new FrameMsg_DroppedNavigation(current_frame_host()->GetRoutingID()));

[nasko, 2017/03/09 05:19:28]

Hmm, why use the new IPC here? The navigation could have been reset for other
reasons than the one this CL is trying to fix.

[clamy, 2017/03/13 13:55:57]

Yes. But I don't think that the cancellation of one renderer-initiation on the
browser side should lead to all loads stopping in the renderer. In particular we
should not stop an ongoing load, but just inform the renderer that it should not
expect the navigation it sent to the browser to continue. This is what the new
FrameMsg_DroppedNavigation is meant to do (I mean to introduce this IPC as
something more general than this particular issue).

   }
 
 }
 
 bool FrameTreeNode::has_started_loading() const {
   return loading_progress_ != kLoadingProgressNotStarted;
 }
 
 void FrameTreeNode::reset_loading_progress() {
   loading_progress_ = kLoadingProgressNotStarted;
@@ skipping 116 matching lines @@
       }
       return parent_->child_at(i + relative_offset);
     }
   }
 
   NOTREACHED() << "FrameTreeNode not found in its parent's children.";
   return nullptr;
 }
 
 }  // namespace content