Avoid sync IPCs for FileSystem API [chromium] (2/4)

chrome/browser/renderer_host/chrome_render_message_filter.cc

Index: chrome/browser/renderer_host/chrome_render_message_filter.cc
diff --git a/chrome/browser/renderer_host/chrome_render_message_filter.cc b/chrome/browser/renderer_host/chrome_render_message_filter.cc
index bb0ed1be0bba69c4ff16d024515d4d3445bc0300..fe9bdf17dd205c0a4bcecc979784ac6c010d4285 100644
--- a/chrome/browser/renderer_host/chrome_render_message_filter.cc
+++ b/chrome/browser/renderer_host/chrome_render_message_filter.cc
@@ -125,6 +125,8 @@ bool ChromeRenderMessageFilter::OnMessageReceived(const IPC::Message& message,
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AllowDatabase, OnAllowDatabase)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AllowDOMStorage, OnAllowDOMStorage)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AllowFileSystem, OnAllowFileSystem)
+    IPC_MESSAGE_HANDLER_GENERIC(ChromeViewHostMsg_RequestFileSystemAccess,
+                        OnRequestFileSystemAccess(message))
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AllowIndexedDB, OnAllowIndexedDB)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CanTriggerClipboardRead,
                         OnCanTriggerClipboardRead)
@@ -446,6 +448,40 @@ void ChromeRenderMessageFilter::OnAllowFileSystem(int render_frame_id,
                  render_process_id_, render_frame_id, origin_url, !*allowed));
 }
 
+void ChromeRenderMessageFilter::OnRequestFileSystemAccess(
+    const IPC::Message& message) {
+  int request_id;
+  GURL origin_url;
+  GURL top_origin_url;
+  if (!ChromeViewHostMsg_RequestFileSystemAccess::Read(
+      &message, &request_id, &origin_url, &top_origin_url))
+    return;
+
+  bool allowed =
+      cookie_settings_->IsSettingCookieAllowed(origin_url, top_origin_url);
+  // Record access to file system for potential display in UI.
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE,
+      base::Bind(
+          &TabSpecificContentSettings::FileSystemAccessedAsyn,

[Fady Samuel, 2014/05/13 17:22:25]

No need for this function, see below.

[Xi Han, 2014/05/13 18:08:37]

Done.

+          message.routing_id(),
+          render_process_id_,
+          request_id,
+          origin_url,
+          !allowed,
+          base::Bind(
+              &ChromeRenderMessageFilter::OnRequestFileSyatemAccessCallbacks,
+              base::Unretained(this))));
+}
+
+void ChromeRenderMessageFilter::OnRequestFileSyatemAccessCallbacks(
+    int routing_id, int render_frame_id, bool allowed) {
+  Send(new ChromeViewMsg_RequestFileSystemAccessResponse(

[Xi Han, 2014/05/13 15:02:51]

Fix a bug by moving the call of sending the asynchronized message to a callback
function. This way guarantees the message will be send after the result (whether
allowed or not) is obtained. 

[Fady Samuel, 2014/05/13 17:22:25]

This is running on the UI thread. Is that intended? I think what you want can be
accomplished by PostTaskAndReply or PostTaskAndReplyWithResult:

https://code.google.com/p/chromium/codesearch#chromium/src/base/task_runner.h...

[Xi Han, 2014/05/13 18:08:37]

Done.

+      routing_id,
+      render_frame_id,
+      allowed));
+}
+
 void ChromeRenderMessageFilter::OnAllowIndexedDB(int render_frame_id,
                                                  const GURL& origin_url,
                                                  const GURL& top_origin_url,