chrome/common/component_flash_hint_file_linux_unittest.cc - Issue 2735113003: Changing SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/component_flash_hint_file_linux_unittest.cc

Issue 2735113003: Changing SpawnChild to return a struct.

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/component_flash_hint_file_linux_unittest.cc

diff --git a/chrome/common/component_flash_hint_file_linux_unittest.cc b/chrome/common/component_flash_hint_file_linux_unittest.cc

index fa3fa1f258433b42ee3da99d66a2a0cdd91c13bb..d67adb8ba962e77d3d17e9eab72ee5a7babc090e 100644

--- a/chrome/common/component_flash_hint_file_linux_unittest.cc

+++ b/chrome/common/component_flash_hint_file_linux_unittest.cc

@@ -157,7 +157,8 @@ MULTIPROCESS_TEST_MAIN(NoExecMountTest) {

}

TEST_F(ComponentFlashHintFileTest, ExecTest2) {

- base::Process process = SpawnChild("NoExecMountTest");

+ base::SpawnChildResult spawn_result = SpawnChild("NoExecMountTest");

+ base::Process process(std::move(spawn_result.process));

ASSERT_TRUE(process.IsValid());

int exit_code = 42;

ASSERT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),