Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: test/cctest/test-run-wasm-relocation-arm.cc

Issue 2735103003: Merged: [wasm] Fix code specialization for empty memory buffer (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-run-wasm-machops.cc ('k') | test/cctest/test-run-wasm-relocation-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-run-wasm-relocation-arm.cc
diff --git a/test/cctest/test-run-wasm-relocation-arm.cc b/test/cctest/test-run-wasm-relocation-arm.cc
index 4fd186e56589772ba5f0bd4f88ce9ac6dc447120..1666b69a57c0e8caf743761a435786177b6708d9 100644
--- a/test/cctest/test-run-wasm-relocation-arm.cc
+++ b/test/cctest/test-run-wasm-relocation-arm.cc
@@ -55,15 +55,10 @@ TEST(WasmRelocationArmMemoryReference) {
// Relocating references by offset
int mode_mask = (1 << RelocInfo::WASM_MEMORY_REFERENCE);
for (RelocIterator it(*code, mode_mask); !it.done(); it.next()) {
- RelocInfo::Mode mode = it.rinfo()->rmode();
- if (RelocInfo::IsWasmMemoryReference(mode)) {
- // Dummy values of size used here as the objective of the test is to
- // verify that the immediate is patched correctly
- it.rinfo()->update_wasm_memory_reference(
- it.rinfo()->wasm_memory_reference(),
- it.rinfo()->wasm_memory_reference() + offset, 1, 2,
- SKIP_ICACHE_FLUSH);
- }
+ DCHECK(RelocInfo::IsWasmMemoryReference(it.rinfo()->rmode()));
+ it.rinfo()->update_wasm_memory_reference(
+ it.rinfo()->wasm_memory_reference(),
+ it.rinfo()->wasm_memory_reference() + offset, SKIP_ICACHE_FLUSH);
}
// Call into relocated code object
@@ -114,13 +109,10 @@ TEST(WasmRelocationArmMemorySizeReference) {
int mode_mask = (1 << RelocInfo::WASM_MEMORY_SIZE_REFERENCE);
for (RelocIterator it(*code, mode_mask); !it.done(); it.next()) {
- RelocInfo::Mode mode = it.rinfo()->rmode();
- if (RelocInfo::IsWasmMemorySizeReference(mode)) {
- it.rinfo()->update_wasm_memory_reference(
- reinterpret_cast<Address>(1234), reinterpret_cast<Address>(1234),
- it.rinfo()->wasm_memory_size_reference(),
- it.rinfo()->wasm_memory_size_reference() + diff, SKIP_ICACHE_FLUSH);
- }
+ DCHECK(RelocInfo::IsWasmMemorySizeReference(it.rinfo()->rmode()));
+ it.rinfo()->update_wasm_memory_size(
+ it.rinfo()->wasm_memory_size_reference(),
+ it.rinfo()->wasm_memory_size_reference() + diff, SKIP_ICACHE_FLUSH);
}
ret_value = runnable.Call();
« no previous file with comments | « test/cctest/compiler/test-run-wasm-machops.cc ('k') | test/cctest/test-run-wasm-relocation-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698