[Mojo Video Capture] Add test coverage for accelerated jpeg decoding

content/browser/renderer_host/media/video_capture_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_CONTROLLER_H_
 #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_CONTROLLER_H_
 
 #include <list>
 #include <memory>
 
@@ skipping 84 matching lines @@
       int buffer_id,
       int frame_feedback_id,
       std::unique_ptr<
           media::VideoCaptureDevice::Client::Buffer::ScopedAccessPermission>
           buffer_read_permission,
       media::mojom::VideoFrameInfoPtr frame_info) override;
   void OnBufferRetired(int buffer_id) override;
   void OnError() override;
   void OnLog(const std::string& message) override;
   void OnStarted() override;
+  void OnStartedUsingGpuDecode() override;
+  void OnStoppedUsingGpuDecode() override;

[mcasas, 2017/03/07 19:39:37]

I don't see the need for OnStoppedUsingGpuDecode():
it's not ending up anywhere in this CL and, once
OnStartedUsingGpuDecode() has been received,
it's fair assumption to think it's running until
OnError or capture stops.

[chfremer, 2017/03/07 22:30:38]

True that it is not strictly needed. I added it for symmetry reasons and for
indicating to the reader that it actually _can_ happen that Gpu decode stops
after it has started. Looking at [1], when the Gpu decoder errors out, the
VCDClient just switches back to software decoding. It does not call OnError() in
that case.

Let me know if you still want me to remove it, and I'll make the change.

[1]
https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device...

 
  private:
   struct ControllerClient;
   typedef std::list<std::unique_ptr<ControllerClient>> ControllerClients;
 
   class BufferContext {
    public:
     BufferContext(
         int buffer_context_id,
         int buffer_id,
@@ skipping 77 matching lines @@
   media::VideoCaptureFormat video_capture_format_;
 
   base::WeakPtrFactory<VideoCaptureController> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoCaptureController);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_CONTROLLER_H_