Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: components/resources/BUILD.gn

Issue 2734973002: Stop setting use_qualified_include to true now that that is the default. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/policy/BUILD.gn ('k') | components/strings/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//printing/features/features.gni") 5 import("//printing/features/features.gni")
6 import("//tools/grit/grit_rule.gni") 6 import("//tools/grit/grit_rule.gni")
7 import("//third_party/brotli/brotli.gni") 7 import("//third_party/brotli/brotli.gni")
8 8
9 about_credits_file = "$target_gen_dir/about_credits.html" 9 about_credits_file = "$target_gen_dir/about_credits.html"
10 about_credits_file_bro = "$target_gen_dir/about_credits.bro" 10 about_credits_file_bro = "$target_gen_dir/about_credits.bro"
11 11
12 group("resources") { 12 group("resources") {
13 public_deps = [ 13 public_deps = [
14 ":components_resources", 14 ":components_resources",
15 ":components_scaled_resources", 15 ":components_scaled_resources",
16 ] 16 ]
17 } 17 }
18 18
19 grit("components_resources") { 19 grit("components_resources") {
20 source = "components_resources.grd" 20 source = "components_resources.grd"
21 use_qualified_include = true
22 21
23 # TODO(hashimoto): Remove this line. 22 # TODO(hashimoto): Remove this line.
24 output_name = "components_resources_new" 23 output_name = "components_resources_new"
25 outputs = [ 24 outputs = [
26 "grit/components_resources.h", 25 "grit/components_resources.h",
27 "components_resources.pak", 26 "components_resources.pak",
28 ] 27 ]
29 output_dir = "$root_gen_dir/components" 28 output_dir = "$root_gen_dir/components"
30 29
31 grit_flags = [ 30 grit_flags = [
32 "-E", 31 "-E",
33 "about_credits_file=" + rebase_path(about_credits_file_bro, root_build_dir), 32 "about_credits_file=" + rebase_path(about_credits_file_bro, root_build_dir),
34 ] 33 ]
35 defines = [ "enable_print_preview=$enable_print_preview" ] 34 defines = [ "enable_print_preview=$enable_print_preview" ]
36 35
37 deps = [ 36 deps = [
38 ":compressed_about_credits", 37 ":compressed_about_credits",
39 ] 38 ]
40 } 39 }
41 40
42 grit("components_scaled_resources") { 41 grit("components_scaled_resources") {
43 source = "components_scaled_resources.grd" 42 source = "components_scaled_resources.grd"
44 43
45 # TODO(thakis): Enable this, https://crbug.com/401588
46 #use_qualified_include = true
47
48 # TODO(hashimoto): Remove this line. 44 # TODO(hashimoto): Remove this line.
49 output_name = "components_scaled_resources_new" 45 output_name = "components_scaled_resources_new"
50 outputs = [ 46 outputs = [
51 "grit/components_scaled_resources.h", 47 "grit/components_scaled_resources.h",
52 "grit/components_scaled_resources_map.cc", 48 "grit/components_scaled_resources_map.cc",
53 "grit/components_scaled_resources_map.h", 49 "grit/components_scaled_resources_map.h",
54 "components_resources_100_percent.pak", 50 "components_resources_100_percent.pak",
55 "components_resources_200_percent.pak", 51 "components_resources_200_percent.pak",
56 "components_resources_300_percent.pak", 52 "components_resources_300_percent.pak",
57 ] 53 ]
(...skipping 22 matching lines...) Expand all
80 ] 76 ]
81 77
82 args = [ 78 args = [
83 "--target-os=$target_os", 79 "--target-os=$target_os",
84 "--depfile", 80 "--depfile",
85 rebase_path(depfile, root_build_dir), 81 rebase_path(depfile, root_build_dir),
86 "credits", 82 "credits",
87 rebase_path(about_credits_file, root_build_dir), 83 rebase_path(about_credits_file, root_build_dir),
88 ] 84 ]
89 } 85 }
OLDNEW
« no previous file with comments | « components/policy/BUILD.gn ('k') | components/strings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698