Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2734943005: Remove moveCursorToSelectionEnd() (Closed)
Patch Set: RESTRICTION_TYPE_PHONE Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 6749aafe832138b29352a637eb1107f508b56817..21f98f29217751370bb367b5b85b8115035bbdd4 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2785,13 +2785,14 @@ void WebContentsImpl::SelectAll() {
RecordAction(base::UserMetricsAction("SelectAll"));
}
-void WebContentsImpl::Unselect() {
+void WebContentsImpl::CollapseSelection() {
RenderFrameHost* focused_frame = GetFocusedFrame();
if (!focused_frame)
return;
- focused_frame->Send(new InputMsg_Unselect(focused_frame->GetRoutingID()));
- RecordAction(base::UserMetricsAction("Unselect"));
+ focused_frame->Send(
+ new InputMsg_CollapseSelection(focused_frame->GetRoutingID()));
+ RecordAction(base::UserMetricsAction("CollapseSelection"));
aelias_OOO_until_Jul13 2017/03/08 21:55:23 I don't think there's any interest in this metric,
yabinh 2017/03/09 02:12:56 Done.
}
void WebContentsImpl::Replace(const base::string16& word) {

Powered by Google App Engine
This is Rietveld 408576698