content/renderer/render_view_browsertest.cc - Issue 2734943005: Remove moveCursorToSelectionEnd()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2734943005: Remove moveCursorToSelectionEnd() (Closed)

Patch Set: For dtrainor@'s review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 38e418b61d263c19cee3bb729e72169ac78c7f41..3f3668c35d9178a5181221c3a63cb0ea19800afe 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -1589,10 +1589,10 @@ TEST_F(RenderViewImplTest, SetEditableSelectionAndComposition) {

EXPECT_EQ(8, info.selectionEnd);

EXPECT_EQ(7, info.compositionStart);

EXPECT_EQ(10, info.compositionEnd);

- frame()->Unselect();

+ frame()->CollapseSelection();

info = controller->textInputInfo();

- EXPECT_EQ(0, info.selectionStart);

- EXPECT_EQ(0, info.selectionEnd);

+ EXPECT_EQ(8, info.selectionStart);

+ EXPECT_EQ(8, info.selectionEnd);

}

TEST_F(RenderViewImplTest, OnExtendSelectionAndDelete) {

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/test_render_frame.h » ('j') | no next file with comments »