content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 2734943005: Remove moveCursorToSelectionEnd()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 2734943005: Remove moveCursorToSelectionEnd() (Closed)

Patch Set: For dtrainor@'s review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index 13aa756e8f9ed9dce4105cc23f939de6f1463569..e8842b52396d3e71954ead417ef05fb4bc85b807 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -216,12 +216,12 @@ import java.util.UUID;

}

@Override

- public void unselect() {

- // Unselect may get triggered when certain selection-related widgets

+ public void collapseSelection() {

+ // collapseSelection may get triggered when certain selection-related widgets

// are destroyed. As the timing for such destruction is unpredictable,

// safely guard against this case.

if (isDestroyed()) return;

- nativeUnselect(mNativeWebContentsAndroid);

+ nativeCollapseSelection(mNativeWebContentsAndroid);

}

@Override

@@ -567,7 +567,7 @@ import java.util.UUID;

private native void nativePaste(long nativeWebContentsAndroid);

private native void nativeReplace(long nativeWebContentsAndroid, String word);

private native void nativeSelectAll(long nativeWebContentsAndroid);

- private native void nativeUnselect(long nativeWebContentsAndroid);

+ private native void nativeCollapseSelection(long nativeWebContentsAndroid);

private native void nativeOnHide(long nativeWebContentsAndroid);

private native void nativeOnShow(long nativeWebContentsAndroid);

private native void nativeSuspendAllMediaPlayers(long nativeWebContentsAndroid);