Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 2734943005: Remove moveCursorToSelectionEnd() (Closed)
Patch Set: For dtrainor@'s review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index 5956eeea7ee8a0fe22e39e42164b02b12ce43359..9d359e5ef75caaf4ecfc727b4e54417ed4ec6971 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -373,9 +373,7 @@ public class ImeAdapter {
restartInput(); // resets mInputConnection
// crbug.com/666982: Restart input may not happen if view is detached from window, but
// we need to unblock in any case. We want to call this after restartInput() to
- // ensure that there is no additional IME operation in the queue, except for
- // moveCursorToSelectionEnd(), which block the IME thread unnecessarily and need
- // refactoring anyways. (crbug.com/662908)
+ // ensure that there is no additional IME operation in the queue.
inputConnection.unblockOnUiThread();
}
}
@@ -447,16 +445,6 @@ public class ImeAdapter {
}
}
- /**
- * Move cursor to the end of the current selection.
- */
- public void moveCursorToSelectionEnd() {
- if (DEBUG_LOGS) Log.w(TAG, "movecursorToEnd");
- if (mInputConnection != null) {
- mInputConnection.moveCursorToSelectionEndOnUiThread();
- }
- }
-
@VisibleForTesting
void setInputTypeForTest(int textInputType) {
mTextInputType = textInputType;

Powered by Google App Engine
This is Rietveld 408576698