content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java - Issue 2734943005: Remove moveCursorToSelectionEnd()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2734943005: Remove moveCursorToSelectionEnd() (Closed)

Patch Set: For dtrainor@'s review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/input_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

index 9b5936055b1ef659241700a224e1e81bd5d7349f..d25a365252de7acd4e55bf98281f52b4507e7070 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

@@ -848,12 +848,8 @@ public class SelectionPopupController extends ActionModeCallbackHelper {

* end if applicable.

void clearSelection() {

- if (isEmpty()) return;

- if (isSelectionEditable()) {

- mImeAdapter.moveCursorToSelectionEnd();

- } else {

- if (mWebContents != null) mWebContents.unselect();

- }

+ if (mWebContents == null || isEmpty()) return;

+ mWebContents.collapseSelection();

}

void onSelectionChanged(String text) {